README.md

@@ -8,9 +8,9 @@ The Full Historical game rule seeds all vanilla CK3 faiths with a doctrine corre
 
 * Criminal in Abrahamic religions (except Adamitism and Insular Christianity where it is Accepted)
 
-Christians, Muslims, and Jews all have long traditions of condemning slavery.
+Christians, Muslims, and Jews all have long traditions of condemning slavery - at least when it's one of the "righteous faith" being enslaved.
 
-Ireland and Scotland were recorded to continue the practice of keeping slaves until as late as 1200s when the Normans cracked down on it. This was technically "Criminal" under Catholicism, but CK3 uses "Insular Christianity" as a shorthand for polygamy and other stuff the Church didn't like. This why I'm making slavery Accepted under Insular Christianity.
+Ireland and Scotland were recorded to continue the practice of keeping slaves until as late as 1200s when the Normans cracked down on it. This was technically "Criminal" under Catholicism, but CK3 uses "Insular Christianity" as a shorthand for polygamy and other stuff the Church didn't like. This is why I'm making slavery Accepted under Insular Christianity.
 
 Slavery is Accepted in Adamitism on the logical grounds that there's no such thing as crime in Adamite belief.
 
@@ -18,7 +18,7 @@ Slavery is Accepted in Adamitism on the logical grounds that there's no such thi
 
 I mostly couldn't find information about slavery in India except under the Muslim sultanates. It's possible that slavery existed in ancient India but it's a controversial topic. Buddhist and Jain teachings pretty strongly condemn slavery, which indicates that it was practiced but frowned upon. Based on this I'm going with the middle ground of Shunned for the Dharmic religions
 
-Slavery of Chinese in China was criminalized but in practice happened a lot on the border regions of the Song Empire, so it's Shunned in Taoism (which is itself a a pretty bad representation of the religious diversity of Chinese spiritual practices, but thems the breaks)
+Slavery in China was criminalized but in practice happened a lot on the border regions of the Song Empire, so it's Shunned in Taoism (which is itself a a pretty bad representation of the religious diversity of Chinese spiritual practices, but thems the breaks.)
 
 * Accepted in Pagan religions (except for Asatru where it is Shunned)
 
@@ -34,7 +34,7 @@ It is well attested that Muslims enslaved loads of non-Muslims, which famously l
 
 Some Christian leaders did denounce slavery, but the majority seem to have turned a blind eye to the practice, with tons of Muslims and Slavs being captured as prisoners of war and traded through Venice and the Byzantine Empire.
 
-I'm not a hundred percent sure whether enslaving pagans is legal in Judaism, but based on the actions of Christians and Muslims I don't think that a theoretical historical Jewish state would be much different.
+Jews were also complicit in the slave trade with Jewish merchants being the main enablers of slave trafficking between the Christian and Muslim worlds.
 
 Pagans were well known for the practice of slavery, see above.
 

descriptor.mod

-version="1.0"
+version="2.0"
 tags={
 	"Religion"
 }
 name="Carnalitas - Historical Slavery Doctrines"
-supported_version="1.0.*"
+supported_version="1.9.*"
\ No newline at end of file

events/carn_slavery_doctrine_seeding_events.txt

@@ -10,13 +10,9 @@
 #
 
 carn_slavery_doctrine_seeding.0001 = {
-	type = empty
+	scope = none
 	hidden = yes
 
-	trigger = {
-		NOT = { has_game_rule = carn_slavery_content_disabled }
-	}
-
 	immediate = {
 		if = {
 			limit = { has_game_rule = carn_slavery_default_religious_doctrine_full_historical }
@@ -26,57 +22,75 @@ carn_slavery_doctrine_seeding.0001 = {
 					# RIGHTEOUS FAITH SLAVERY
 
 					if = {
-						limit = { religion = { is_in_family = rf_abrahamic } } # Righteous Faith Slavery is Criminal for Abrahamic religions, unless you're adamite or insular
+						limit = {
+							NOR = {
+								has_doctrine = carn_doctrine_same_slavery_crime
+								has_doctrine = carn_doctrine_same_slavery_shunned
+								has_doctrine = carn_doctrine_same_slavery_accepted
+							}
+						}
 						if = {
-							limit = {
-								OR = {
-									this = faith:adamites
-									this = faith:insular_celtic
+							limit = { religion = { is_in_family = rf_abrahamic } } # Righteous Faith Slavery is Criminal for Abrahamic religions, unless you're adamite or insular
+							if = {
+								limit = {
+									OR = {
+										this = faith:adamites
+										this = faith:insular_celtic
+									}
 								}
+								add_doctrine = carn_doctrine_same_slavery_accepted
+							}
+							else = {
+								add_doctrine = carn_doctrine_same_slavery_crime
 							}
-							add_doctrine = carn_doctrine_same_slavery_accepted
-						}
-						else = {
-							add_doctrine = carn_doctrine_same_slavery_crime
 						}
-					}
-					else_if = {
-						limit = { religion = { is_in_family = rf_eastern } } # Righteous Faith Slavery is Shunned for Eastern religions
-						add_doctrine = carn_doctrine_same_slavery_shunned
-					}
-					else = { # Same Religion Slavery is Accepted for pagans, unless you're Norse
-						if = {
-							limit = { this = faith:norse_pagan }
+						else_if = {
+							limit = { religion = { is_in_family = rf_eastern } } # Righteous Faith Slavery is Shunned for Eastern religions
 							add_doctrine = carn_doctrine_same_slavery_shunned
 						}
-						else = {
-							add_doctrine = carn_doctrine_same_slavery_accepted
+						else = { # Same Religion Slavery is Accepted for pagans, unless you're Norse
+							if = {
+								limit = { this = faith:norse_pagan }
+								add_doctrine = carn_doctrine_same_slavery_shunned
+							}
+							else = {
+								add_doctrine = carn_doctrine_same_slavery_accepted
+							}
 						}
 					}
 
 					# HOSTILE FAITH SLAVERY
 
 					if = {
-						limit = { religion = { is_in_family = rf_abrahamic } } # Hostile Faith Slavery is Accepted in Abrahamic religions, unless you're waldensian or bogomilist
+						limit = {
+							NOR = {
+								has_doctrine = carn_doctrine_other_slavery_crime
+								has_doctrine = carn_doctrine_other_slavery_shunned
+								has_doctrine = carn_doctrine_other_slavery_accepted
+							}
+						}
 						if = {
-							limit = { this = faith:waldensian }
-							add_doctrine = carn_doctrine_other_slavery_shunned
+							limit = { religion = { is_in_family = rf_abrahamic } } # Hostile Faith Slavery is Accepted in Abrahamic religions, unless you're waldensian or bogomilist
+							if = {
+								limit = { this = faith:waldensian }
+								add_doctrine = carn_doctrine_other_slavery_shunned
+							}
+							else_if = {
+								limit = { this = faith:bogomilist }
+								add_doctrine = carn_doctrine_other_slavery_crime
+							}
+							else = {
+								add_doctrine = carn_doctrine_other_slavery_accepted
+							}
 						}
 						else_if = {
-							limit = { this = faith:bogomilist }
-							add_doctrine = carn_doctrine_other_slavery_crime
+							limit = { religion = { is_in_family = rf_eastern } } # Hostile Faith Slavery is Shunned in Eastern religions
+							add_doctrine = carn_doctrine_other_slavery_shunned
 						}
-						else = {
+						else = { # Hostile Faith Slavery is Accepted in pagan religions
 							add_doctrine = carn_doctrine_other_slavery_accepted
 						}
 					}
-					else_if = {
-						limit = { religion = { is_in_family = rf_eastern } } # Hostile Faith Slavery is Shunned in Eastern religions
-						add_doctrine = carn_doctrine_other_slavery_shunned
-					}
-					else = { # Hostile Faith Slavery is Accepted in pagan religions
-						add_doctrine = carn_doctrine_other_slavery_accepted
-					}
 				}
 			}
 		}
@@ -95,13 +109,8 @@ carn_slavery_doctrine_seeding.0001 = {
 #
 
 carn_slavery_doctrine_seeding.0002 = {
-	type = empty
 	hidden = yes
 
-	trigger = {
-		NOT = { has_game_rule = carn_slavery_content_disabled }
-	}
-
 	immediate = {
 		root.faith = {
 			carn_seed_slavery_doctrines_effect = yes

localization/french/carn_full_historical_game_rule_l_french.yml

+l_french:
+setting_carn_slavery_default_religious_doctrine_full_historical:1 "#high Complètement historique#!"
+setting_carn_slavery_default_religious_doctrine_full_historical_desc:1 "Toutes les fois ont des doctrines appropriées pour l'$carn_doctrine_same_slavery_name$ et l'$carn_doctrine_other_slavery_name$ basées sur des recherches historiques."

localization/german/carn_full_historical_game_rule_l_german.yml

+l_german:
+setting_carn_slavery_default_religious_doctrine_full_historical:1 "#high Komplett historisch#!"
+setting_carn_slavery_default_religious_doctrine_full_historical_desc:1 "Alle Glaubensrichtungen haben genaue Lehren für $carn_doctrine_same_slavery_name$ und $carn_doctrine_other_slavery_name$, die auf historischen Fakten basieren."