From 4350c73029409bcb55c6a45db758282b46b1417f Mon Sep 17 00:00:00 2001
From: HPotato <12221-hpotato@users.noreply.gitgud.io>
Date: Sat, 9 Jan 2021 14:19:17 +1030
Subject: [PATCH] Fix n being 0 instead of NaN where numEditor.value = ""
---
src/js/rulesAssistantOptions.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/js/rulesAssistantOptions.js b/src/js/rulesAssistantOptions.js
index b7ea7a12dfe..5de3f8da27e 100644
--- a/src/js/rulesAssistantOptions.js
+++ b/src/js/rulesAssistantOptions.js
@@ -948,8 +948,8 @@ App.RA.options = (function() {
}
getTextData() {
- const n = Number(this.numEditor.value); // Attempt to convert numEditor.value to number,
- const v = isNaN(n) ? this.numEditor.value : Math.floor(n); // return value as number if success (should result in realData being of number)
+ const n = this.numEditor.value !== "" ? Number(this.numEditor.value) : Number.NaN; // Attempt to convert numEditor.value to number,
+ const v = isNaN(n) ? this.numEditor.value : Math.floor(n); // return value as number if !NaN (should result in realValue being of number)
return v === null || v === "" ? null : { cond: this.opSelector.value, val: v };
}
}
--
GitLab