From 6bb7c94c36e5279dcd32f06a716ad3ce88fa67a4 Mon Sep 17 00:00:00 2001
From: Arkerthan <arkerthan@gmail.com>
Date: Mon, 14 Dec 2020 20:57:58 +0100
Subject: [PATCH] Make the eslint job not fail despite errors type warnings.

---
 .gitlab-ci.yml | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 56cc5dd6ad5..248e8c623e7 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -14,10 +14,8 @@ eslint:
     - npm install
     #- npm ci ### should use this for automated testing instead of "npm install", but we need a package-lock.json for it.
     - npm install eslint-formatter-gitlab
-    - npx eslint --format gitlab .
-  # errors make eslint return 1, for now though we want the pipeline not to ail when we eslint errors.
-  # trying to add " ; exit 0" or " ; echo 0" let the build fail anyways for some reason.
-  allow_failure: true
+    # > /dev/null 2>&1 || FAILED=true to make error type warnings not fail the job
+    - npx eslint --format gitlab . > /dev/null 2>&1 || FAILED=true
   artifacts:
     reports:
       codequality: gl-codequality.json
-- 
GitLab