From 8b4f3aa02ae35dd6ecb5cb60b040289eea960674 Mon Sep 17 00:00:00 2001
From: ezsh <ezsh.junk@gmail.com>
Date: Thu, 8 Oct 2020 20:24:44 +0200
Subject: [PATCH] Do not ignore return values

---
 js/003-data/policiesData.js | 31 +++++++++++++------------------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/js/003-data/policiesData.js b/js/003-data/policiesData.js
index ef5569ce3d3..13fdd6416ca 100644
--- a/js/003-data/policiesData.js
+++ b/js/003-data/policiesData.js
@@ -714,9 +714,9 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.customRetirementAge,
 								v => {
-									Math.clamp(v, 20, 120);
-									V.customRetirementAge = v;
-									V.retirementAge = v;
+									const age = Math.clamp(v, 20, 120);
+									V.customRetirementAge = age;
+									V.retirementAge = age;
 									policy("RetirementPolicies");
 								},
 								true
@@ -744,9 +744,9 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.customRetirementAge,
 								v => {
-									Math.clamp(v, 20, 120);
-									V.customRetirementAge = v;
-									V.retirementAge = v;
+									const age = Math.clamp(v, 20, 120);
+									V.customRetirementAge = age;
+									V.retirementAge = age;
 									policy("RetirementPolicies");
 								},
 								true
@@ -815,8 +815,7 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.policies.retirement.sex,
 								v => {
-									Math.clamp(v, 1, 10000000);
-									V.policies.retirement.sex = v;
+									V.policies.retirement.sex = Math.clamp(v, 1, 1e7);;
 									policy("RetirementPolicies");
 								},
 								true
@@ -846,8 +845,7 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.policies.retirement.milk,
 								v => {
-									V.policies.retirement.milk = v;
-									Math.clamp(v, 1, 100000000);
+									V.policies.retirement.milk = Math.clamp(v, 1, 1e8);
 									policy("RetirementPolicies");
 								},
 								true
@@ -877,8 +875,7 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.policies.retirement.cum,
 								v => {
-									Math.clamp(v, 1, 1000000000);
-									V.policies.retirement.cum = v;
+									V.policies.retirement.cum = Math.clamp(v, 1, 1e9);;
 									policy("RetirementPolicies");
 								},
 								true
@@ -908,8 +905,7 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.policies.retirement.births,
 								v => {
-									Math.clamp(v, 1, 1000000);
-									V.policies.retirement.births = v;
+									V.policies.retirement.births = Math.clamp(v, 1, 1e6);
 									policy("RetirementPolicies");
 								},
 								true
@@ -939,8 +935,7 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.policies.retirement.kills,
 								v => {
-									Math.clamp(v, 1, 1000000);
-									V.policies.retirement.kills = v;
+									V.policies.retirement.kills = Math.clamp(v, 1, 1e6);;
 									policy("RetirementPolicies");
 								},
 								true
@@ -986,8 +981,8 @@ App.Data.Policies.Selection = {
 							App.UI.DOM.makeTextBox(
 								V.customMenialRetirementAge,
 								v => {
-									Math.clamp(v, 20, 120);
-									V.customMenialRetirementAge = v;
+									const age = Math.clamp(v, 20, 120);
+									V.customMenialRetirementAge = age;
 									V.customRetirementAge = Math.clamp(V.customRetirementAge, 20, V.customMenialRetirementAge);
 									if (V.customMenialRetirementAge < 45) {
 										V.retirementAge = V.customMenialRetirementAge;
-- 
GitLab