From c919b420291f920a481a83625ad40a5c0d4d89ab Mon Sep 17 00:00:00 2001 From: Svornost <11434-svornost@users.noreply.gitgud.io> Date: Wed, 21 Oct 2020 12:44:14 -0700 Subject: [PATCH] Remove falsey haystacks before searching for the needle. Prevents slaves without surnames from matching the query "name is like 0". --- src/js/findSlave.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/findSlave.js b/src/js/findSlave.js index bd138ce9bdc..c0f8f9e39d4 100644 --- a/src/js/findSlave.js +++ b/src/js/findSlave.js @@ -7,8 +7,8 @@ App.FindSlave = {}; * @returns {boolean} */ App.FindSlave._fragmentSearch = function(haystacks, needles) { - const hs = haystacks.join(" "); - return needles.every((needle) => { return needle.test(hs); }); + const hs = haystacks.filter(h => !!h).join(" "); + return needles.every((needle) => needle.test(hs)); }; /** -- GitLab