From 0babc4b91d6023720ed3e4572851b7a56b9ba110 Mon Sep 17 00:00:00 2001
From: franklygeorge <54015-franklygeorge@users.noreply.gitgud.io>
Date: Thu, 3 Oct 2024 17:46:12 -0400
Subject: [PATCH] Fix 5429
---
src/js/states/001-GenePoolRecord.js | 3 +--
src/pregmod/editGenetics.js | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/js/states/001-GenePoolRecord.js b/src/js/states/001-GenePoolRecord.js
index 464d4fe16a5..97074c4f84f 100644
--- a/src/js/states/001-GenePoolRecord.js
+++ b/src/js/states/001-GenePoolRecord.js
@@ -45,8 +45,7 @@ globalThis.getGenePoolRecord = (key, missingOkay=false, write=false) => {
target[key] = value;
return true;
}
- console.error(`Attempt to set '${String(key)}' in read only gene pool record with ID '${ID}' to '${value}' was blocked`);
- return false;
+ throw new Error(`Attempt to set '${String(key)}' in read only gene pool record with ID '${ID}' to '${value}' was blocked`);
},
/**
* @param {Partial<FC.GenePoolRecord>} target
diff --git a/src/pregmod/editGenetics.js b/src/pregmod/editGenetics.js
index 9c56ebbd602..a1ebe570402 100644
--- a/src/pregmod/editGenetics.js
+++ b/src/pregmod/editGenetics.js
@@ -646,7 +646,7 @@ App.UI.editGenetics = function() {
/* The PC */
return birthFullName(V.PC) + ' (PC)';
} else {
- let parent = getGenePoolRecord(id);
+ let parent = getGenePoolRecord(id, undefined, true);
return parent
? birthFullName(parent)
: App.Events.makeNode([
@@ -716,7 +716,7 @@ App.UI.editGenetics = function() {
jQuery('button.selectedslave').removeClass('selectedslave');
el.addClass('selectedslave');
// @ts-ignore you shouldn't access V.genePool directly because it isn't supposed to change; this is an exception; For normal use use getGenePoolRecord()
- let slave = getGenePoolRecord(id);
+ let slave = getGenePoolRecord(id, undefined, true);
geneDetails.html(geneDetailsFunction(slave));
let numberEditorOpen = function() {
--
GitLab