From 1b148e5138d8a3d69b2170d161fb27f58d5a7264 Mon Sep 17 00:00:00 2001
From: Anu <anulithic@gmail.com>
Date: Thu, 27 Mar 2025 15:55:58 -0700
Subject: [PATCH] Small optimization and comments
---
src/npc/generate/generateNewSlaveJS.js | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/npc/generate/generateNewSlaveJS.js b/src/npc/generate/generateNewSlaveJS.js
index f4be6eddea0..918bb791037 100644
--- a/src/npc/generate/generateNewSlaveJS.js
+++ b/src/npc/generate/generateNewSlaveJS.js
@@ -92,14 +92,11 @@ globalThis.GenerateNewSlave = (function() {
sex = sex || GenerateChromosome(getSeed());
if (sex === "XY") {
generateXYGeneticQuirks();
- } else {
- generateXXGeneticQuirks();
- }
-
- preGenCombinedStats();
- if (sex === "XY") {
+ preGenCombinedStats();
GenerateXYSlave();
} else {
+ generateXXGeneticQuirks();
+ preGenCombinedStats();
GenerateXXSlave();
}
postGenCleanup();
@@ -1218,7 +1215,7 @@ globalThis.GenerateNewSlave = (function() {
}
chance = jsRandom(1, 20000, undefined, getSeed());
if (chance >= 19990) {
- slave.geneticQuirks.heterochromia = 2;
+ slave.geneticQuirks.heterochromia = 2; // this is a placeholder value, which is converted to a color string by setGeneticEyeColor() later in generation
} else if (chance >= 19750) {
slave.geneticQuirks.heterochromia = 1;
}
@@ -1336,7 +1333,7 @@ globalThis.GenerateNewSlave = (function() {
}
chance = jsRandom(1, 20000, undefined, getSeed());
if (chance >= 19990) {
- slave.geneticQuirks.heterochromia = 2;
+ slave.geneticQuirks.heterochromia = 2; // this is a placeholder value, which is converted to a color string by setGeneticEyeColor() later in generation
} else if (chance >= 19750) {
slave.geneticQuirks.heterochromia = 1;
}
--
GitLab