From 20fd0910e57cb87ba85898afc1b602b57524b499 Mon Sep 17 00:00:00 2001
From: prndev <prndev@users.noreply.github.com>
Date: Mon, 20 Aug 2018 22:30:18 +0200
Subject: [PATCH] Added batch file for running embed_favicon on Windows.

Closes #246.
---
 devTools/embed_favicon.bat | 5 +++++
 devTools/embed_favicon.py  | 6 +++++-
 2 files changed, 10 insertions(+), 1 deletion(-)
 create mode 100644 devTools/embed_favicon.bat

diff --git a/devTools/embed_favicon.bat b/devTools/embed_favicon.bat
new file mode 100644
index 00000000000..8dff88d8508
--- /dev/null
+++ b/devTools/embed_favicon.bat
@@ -0,0 +1,5 @@
+@echo off
+pushd %~dp0
+embed_favicon.py
+popd
+pause
diff --git a/devTools/embed_favicon.py b/devTools/embed_favicon.py
index 4c48e7fcc47..4b59bb93be8 100755
--- a/devTools/embed_favicon.py
+++ b/devTools/embed_favicon.py
@@ -56,6 +56,7 @@ if __name__ == "__main__":
     size_from_filename = re.compile(r'([0-9]+)\....$')
     favicons_html = []
     for fp in favicons_paths:
+        print('Found favicon source file "%s".'%(fp))
         # get mimetype by file extension
         mimetype = ext2mimetype[fp[-4:]]
         if (mimetype == 'image/x-icon'):
@@ -74,7 +75,8 @@ if __name__ == "__main__":
         )
 
     # modify header file
-    with open(header_html_path,'r+') as hf:
+    with open(header_html_path,'r+',encoding='utf-8') as hf:
+        print('Rewriting "%s"...'%(header_html_path))
         lines_in = hf.readlines() # read whole file
         lines_out = []
         for line in lines_in:
@@ -87,3 +89,5 @@ if __name__ == "__main__":
         hf.seek(0) # move to beginning of file
         hf.write(''.join(lines_out)) # overwrite with new data
         hf.truncate() # remove trailing old data
+        
+    print('Finished.')
-- 
GitLab