From 39b997bddd8e3b3dab136f7b33a6bd273d67c80f Mon Sep 17 00:00:00 2001 From: lowercasedonkey <lowercasedonkey@gmail.com> Date: Thu, 29 Apr 2021 15:23:04 -0400 Subject: [PATCH] fixes --- css/rulesAssistant/raSummary.css | 16 +++++++--------- src/js/rulesAssistantSummary.js | 9 ++++----- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/css/rulesAssistant/raSummary.css b/css/rulesAssistant/raSummary.css index 129c552932a..ce52cabf9d0 100644 --- a/css/rulesAssistant/raSummary.css +++ b/css/rulesAssistant/raSummary.css @@ -3,20 +3,17 @@ height: 90vh } -.ra-sum { +table.ra-sum { text-align: left; border-collapse: separate; empty-cells: hide; - + border: 1px solid grey; } -.ra-sum:nth-child(even) { +/*ra-sum:nth-child(even) { background-color: #f2f2f2; -} - -.ra-sum-cell { - border-style: solid; - border: 1px; - border-color: grey; +}*/ +td.ra-sum { + border: 1px solid grey; } tr.ra-sum.header { @@ -24,6 +21,7 @@ tr.ra-sum.header { top:0px; z-index:2; background:#111; + border: inherit } th.ra-sum.first-header-cell { diff --git a/src/js/rulesAssistantSummary.js b/src/js/rulesAssistantSummary.js index 796fece3ec4..590be477661 100644 --- a/src/js/rulesAssistantSummary.js +++ b/src/js/rulesAssistantSummary.js @@ -28,7 +28,7 @@ new App.DomPassage("Rules Assistant Summary", () => { /* make rest of row title */ for (const rule of rules) { - App.UI.DOM.appendNewElement("th", header, rule.name, "ra-sum-cell"); + App.UI.DOM.appendNewElement("th", header, rule.name); } const setters = rules.map(r => r.set); @@ -87,12 +87,11 @@ new App.DomPassage("Rules Assistant Summary", () => { if (!cells.some(v => v !== null)) { // skip empty rows return; } - const row = App.UI.DOM.makeElement("tr"); + const row = App.UI.DOM.makeElement("tr", null, "ra-sum"); function ruleSetValueToString(v) { if (typeof v === 'object') { if (v.hasOwnProperty('cond') && v.hasOwnProperty('val')) { - console.log(v) return `${v.cond} ${v.val}`; } else if (v.hasOwnProperty('min') && v.hasOwnProperty('max')) { return `${v.min} to ${v.max}`; @@ -103,10 +102,10 @@ new App.DomPassage("Rules Assistant Summary", () => { return `${v}`; } - App.UI.DOM.appendNewElement("td", row, path.join('.'), ["ra-sum", "row-title", "ra-sum-cell"]); + App.UI.DOM.appendNewElement("td", row, path.join('.'), ["ra-sum", "row-title"]); for (const cell of cells) { const content = cell !== null ? ruleSetValueToString(cell) : null; - App.UI.DOM.appendNewElement("td", row, content, "ra-sum-cell"); + App.UI.DOM.appendNewElement("td", row, content, "ra-sum"); } table.append(row); } -- GitLab