From 6064322c7fc0325e89f133e4403308038e3a2708 Mon Sep 17 00:00:00 2001
From: Blank_Alt <12406-Blank_Alt@users.noreply.gitgud.io>
Date: Thu, 3 Mar 2022 19:32:45 +0000
Subject: [PATCH] Improve contrib
---
CONTRIBUTING.md | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index ed753573747..c291d1f7dfb 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -141,15 +141,11 @@ const foo = {
New code should generally get organized into the `App` namespace. See [fc-js-init.js](js/002-config/fc-js-init.js) for a rough outline.
## JavaScript Features
-
-* Avoid using very new JavaScript features
- * Generally, we're currently targeting ECMAScript 2018, though we use a few widely-implemented ECMAScript 2019
- features, like `globalThis`.
-* Conversely, do use modern features, it's not 2010 anymore and we don't try to support Internet Explorer or anything
- stupid like that.
- * use `let`/`const` rather than `var`
- * prefer fat arrow functions to inline long-form functions
- * etc.
+* Generally, we're currently targeting ECMAScript 2021.
+* It's not 2010 anymore and we don't try to support Internet Explorer or anything stupid like that.
+* use `let`/`const` rather than `var`
+* prefer fat arrow functions to inline long-form functions
+* etc.
## Code quality
@@ -214,3 +210,4 @@ errors, it's not totally clean as is and there are a few false positives.
* [Classes in Game State](https://gitgud.io/pregmodfan/fc-pregmod/-/issues/696)
* [Self executing functions](https://gitgud.io/pregmodfan/fc-pregmod/-/issues/2325)
* [Sort a map](https://gitgud.io/pregmodfan/fc-pregmod/-/issues/2642)
+* [How to create a Merge Request (MR)](https://gitgud.io/pregmodfan/fc-pregmod/-/issues/3903)
--
GitLab