diff --git a/src/js/rulesAssistant.js b/src/js/rulesAssistant.js index 7b20fb6d62b4ccb1afbf3d230e7fef743b8abc93..fe9d0269670564f96ad6ab746d878e851a2c1274 100644 --- a/src/js/rulesAssistant.js +++ b/src/js/rulesAssistant.js @@ -407,31 +407,45 @@ window.RASummaryCell = function RASummaryCell() { let rules = Object.keys(V.defaultRules); /* needed to determine number of rule sets (chart width)*/ let keys = Object.keys(V.defaultRules[0].set); /* needed to determine length of rules (chart height)*/ let values; + let display = 0; /* start row title */ r += `<tr><td></td>`; /* make rest of row title */ - for (i=0; i<=(rules.length-1); i++) { + for (i = 0; i < rules.length; i++) { r += `<td>${V.defaultRules[i].name}</td>`; } r += `</tr>`; /* A row for every condition the RA can set. */ /* start loop for row*/ - for (i=0; i<=(keys.length-1); i++) { /* i is for rows/"what they are fed" */ - /* make row title */ - r += `<tr><td>${keys[i]}</td>`; - /* make rest of cells */ - for (j=0; j<=(rules.length-1); j++) { /* j is the rule set it comes from/"obediant slaves" */ + for (i = 0; i < keys.length; i++) { /* i is for rows/"what they are fed" */ + + /* Check if this row will have anything interesting*/ + for (j = 0; j < rules.length; j++) { /* j is the rule set it comes from/"obediant slaves" */ values = V.defaultRules[j].set[keys[i]]; - if (values === "no default setting" || !values) { - r += `<td></td>`; - } else { - r += `<td>${V.defaultRules[j].set[keys[i]]}</td>`; + if (values && values !== "no default setting") { + display++; } } - r += `</tr>`; + + /* Show the interesting row */ + if (display > 0) { + /* make row title */ + r += `<tr><td>${keys[i]}</td>`; + /* make rest of cells */ + for (j = 0; j < rules.length; j++) { + values = V.defaultRules[j].set[keys[i]]; + if (values === "no default setting" || !values) { + r += `<td></td>`; + } else { + r += `<td>${V.defaultRules[j].set[keys[i]]}</td>`; + } + } + display = 0; + r += `</tr>`; + } } return r; };