diff --git a/src/events/001-base/baseEvent.js b/src/events/001-base/baseEvent.js index 67bab1f667c67612817c957eb387a9d51c1983ad..bd14a10f55da84020788990198f41fd24a92797d 100644 --- a/src/events/001-base/baseEvent.js +++ b/src/events/001-base/baseEvent.js @@ -2,7 +2,7 @@ App.Events.BaseEvent = class BaseEvent { /** build a new event * parameters are necessary for serialization (so that saving with the event active will work correctly) and should not normally be used directly - * child classes should forward to this implementation */ + * child classes will inherit this implementation automatically, and should not normally need their own constructor implementation */ constructor(actors, params) { /** @member {Array<number>} actors - a list of IDs for the actors participating in this event. */ this.actors = actors || []; diff --git a/src/events/RESS/lazyEvening.js b/src/events/RESS/lazyEvening.js index 2c9223306d59b0a6680df496b51f890ce5c54589..f7197cbc03837bf10aaa723cdd5f7aca9eea1a5e 100644 --- a/src/events/RESS/lazyEvening.js +++ b/src/events/RESS/lazyEvening.js @@ -1,8 +1,4 @@ App.Events.RESSLazyEvening = class RESSLazyEvening extends App.Events.BaseEvent { - constructor(actors, params) { - super(actors, params); - } - eventPrerequisites() { return []; } diff --git a/src/events/RESS/muscles.js b/src/events/RESS/muscles.js index 06dff12a6a2577635a02a166cc9c30a4038786b2..2671d77a2ffa7263a8e883fddba0c4680a590467 100644 --- a/src/events/RESS/muscles.js +++ b/src/events/RESS/muscles.js @@ -1,8 +1,4 @@ App.Events.RESSMuscles = class RESSMuscles extends App.Events.BaseEvent { - constructor(actors, params) { - super(actors, params); - } - eventPrerequisites() { return []; } diff --git a/src/events/eventUtils.js b/src/events/eventUtils.js index 9d3b23f75dc0fc0742faeecd824850d03febb0ef..8d67393b3c7a667a150b3b716395c4932b97b3d8 100644 --- a/src/events/eventUtils.js +++ b/src/events/eventUtils.js @@ -111,10 +111,10 @@ App.Events.Result = class { this.note = note; } - handle() { + handle(resultSpanID) { let frag = document.createDocumentFragment(); $(frag).append(App.Events.spaceSentences(this.handler())); - App.UI.DOM.replace("#result", frag); + App.UI.DOM.replace(`#${resultSpanID}`, frag); } /** build the response DOM (for use by addResponses) @@ -124,7 +124,7 @@ App.Events.Result = class { makeResponse(node) { let wrote = false; if (this.text && this.handler) { - node.appendChild(App.UI.DOM.link(this.text, () => this.handle())); + node.appendChild(App.UI.DOM.link(this.text, () => this.handle(node.id))); wrote = true; } if (this.note) { @@ -138,10 +138,11 @@ App.Events.Result = class { /** add a list of results for an event * @param {HTMLElement} node * @param {Array<App.Events.Result>} results + * @param {string} [elementID="result"] */ -App.Events.addResponses = function(node, results) { +App.Events.addResponses = function(node, results, elementID="result") { let resultSpan = document.createElement("span"); - resultSpan.id = "result"; + resultSpan.id = elementID; for (const result of results) { if (result.makeResponse(resultSpan)) { resultSpan.appendChild(document.createElement("br")); diff --git a/src/events/reDevotees.js b/src/events/reDevotees.js index 588cf91541880648899f85b0d118404ffac29573..dd997e8f98e4768c577a47dc1b15c25b88ced2a4 100644 --- a/src/events/reDevotees.js +++ b/src/events/reDevotees.js @@ -1,8 +1,4 @@ App.Events.REDevotees = class REDevotees extends App.Events.BaseEvent { - constructor(actors, params) { - super(actors, params); - } - eventPrerequisites() { return []; // always valid if sufficient actors can be cast successfully }