diff --git a/src/neighbor/arcologyDiplomacy.js b/src/neighbor/arcologyDiplomacy.js index 1df56958aefbae6d09ccb4983468eba2eb3560f8..0f0a1c1962150e599433cef0f5d0514e43a633dd 100644 --- a/src/neighbor/arcologyDiplomacy.js +++ b/src/neighbor/arcologyDiplomacy.js @@ -6,13 +6,10 @@ App.Neighbor.opinion = function(activeID, targetID) { const activeArcology = V.arcologies[activeID]; const targetArcology = V.arcologies[targetID]; - if (typeof activeArcology.FSNull === "undefined") { activeArcology.FSNull = "unset"; } - if (typeof targetArcology.FSNull === "undefined") { targetArcology.FSNull = "unset"; } + const {shared, conflicting} = FutureSocieties.diplomaticFSes(activeID, targetID); let opinion = 0; - const {shared, conflicting} = FutureSocieties.diplomaticFSes(activeID, targetID); - for (const fs of shared) { opinion += activeArcology[fs]; opinion += targetArcology[fs]; @@ -32,7 +29,7 @@ App.Neighbor.opinion = function(activeID, targetID) { } } - return opinion = Number(opinion) || 0; + return opinion; }; /** set a new influence target for a given arcology