diff --git a/devTools/scripts/dependencyCheck.bat b/devTools/scripts/dependencyCheck.bat index 90f70a088f7b12b66d7bdf1ab9591576ced31eb3..c3f359ff4ede3b51f481491b1c1a571fce011ccf 100644 --- a/devTools/scripts/dependencyCheck.bat +++ b/devTools/scripts/dependencyCheck.bat @@ -72,10 +72,11 @@ ECHO The sanity checks have this as a hard dependency. GOTO :eof :nodeMessage -ECHO Node.js, https://nodejs.org/, enables all of the new sanity checks and the new compiler. +ECHO Node.js, https://nodejs.org/, enables all of the new sanity checks and the advanced compiler. ECHO Allows for things like: ECHO Source maps for easier debugging: https://dzone.com/articles/what-are-source-maps-and-how-to-properly-use-them ECHO Javascript linting to catch bugs early using ESLint: https://eslint.org/ +ECHO Javascript type checking to catch bugs early using the Typescript compiler: https://www.typescriptlang.org/ ECHO Extra sanity checks to catch common errors. ECHO Spell checking using the cSpell project: https://cspell.org/ :: TODO: @franklygeorge: update as we add the rest of the features diff --git a/devTools/scripts/dependencyCheck.sh b/devTools/scripts/dependencyCheck.sh index d7140120c98e2c6ce6f54855197acaa02c947d58..81663585b088619048b9e6ca86ba0a68da9948a4 100755 --- a/devTools/scripts/dependencyCheck.sh +++ b/devTools/scripts/dependencyCheck.sh @@ -155,10 +155,11 @@ if [[ ! "$git" ]]; then fi if [[ ! "$node" ]]; then - echo " Node.js, https://nodejs.org/, enables all of the new sanity checks and the new compiler." + echo " Node.js, https://nodejs.org/, enables all of the new sanity checks and the advanced compiler." echo " Allows for things like:" echo " Source maps for easier debugging: https://dzone.com/articles/what-are-source-maps-and-how-to-properly-use-them" echo " Javascript linting to catch bugs early using ESLint: https://eslint.org/" + echo " Javascript type checking to catch bugs early using the Typescript compiler: https://www.typescriptlang.org/" echo " Extra sanity checks to catch common errors." echo " Spell checking using the cSpell project: https://cspell.org/" # TODO: @franklygeorge: update as we add the rest of the features diff --git a/devTools/scripts/detectChanges.js b/devTools/scripts/detectChanges.js index 4cf789ae013878495faad7ea43a279482ec5087c..6b7a5f8223ac49f7fd14241ee650e247109cef1c 100644 --- a/devTools/scripts/detectChanges.js +++ b/devTools/scripts/detectChanges.js @@ -101,15 +101,17 @@ class ChangeParser { .then((answers) => { choice = answers.choice; }); - // TODO: @franklygeorge when the settings menu exists, add note about the fact that they can always change their mind + const batSh = (process.platform === "win32") ? "bat" : "sh"; if (choice === "Yes" || choice === "Yes, don't ask again") { if (choice === "Yes, don't ask again") { + console.log(`You can change this setting in setup.${batSh} -> 'Edit Miscellaneous Settings'`); settings.fetchUpstreamBranch = 1; jetpack.write("settings.json", settings, {atomic: true}); } this.hasPermission = true; // user has decide to fetch the upstream branch } else if (choice === "No" || choice === "No, don't ask again") { if (choice === "No, don't ask again") { + console.log(`You can change this setting in setup.${batSh} -> 'Edit Miscellaneous Settings'`); settings.fetchUpstreamBranch = -1; jetpack.write("settings.json", settings, {atomic: true}); } diff --git a/devTools/scripts/extraChecks.js b/devTools/scripts/extraChecks.js index ba497576721605fdceebc982aedf7728b1f00060..d0a509fdf5ba638013168972193d82f9a73e01a5 100644 --- a/devTools/scripts/extraChecks.js +++ b/devTools/scripts/extraChecks.js @@ -40,7 +40,6 @@ const customArticles = [ "a MILF", "a SHIT", "a MUCH", - // TODO:@franklygeorge move this to settings.json ] .map((entry) => entry.slice(0, 1).toLowerCase() + entry.slice(1));