End Of Week Arcology Management - Max and near max prosperity skips business assistant actions

Expected Behavior

Business Assistant actions should be taken at the end of every week.

Current Behavior

If the arcology is at maximum prosperity, the Business Assistant does not act: image

Possible Solution

Looked a bit into the code, seems that the check for max or near maximum prosperity in src\endWeek\economics\arcmgmt.js:397 skips all prosperity changes. First check is for maximum prosperity, then an if-else checks if the prosperity is close to maximum, the following else goes from lines 402 to 717.
The actions of the Business Assistant are taken after prosperity changes are calculated from lines 653 to line 709.

In the same vein, slave school and food updates also seem to be in this section, so this may be related to #2587 (closed).
Although not very sure about food, since I don't play with that and it's referenced differently than slace schools and the BA.

I'd guess that this is unintended and was simply lost in that huge if statement at some point.

Solution could be to move the brace from line 717 to line 648. This would run the schools function, the BA if statement and the food report render.

Steps to Reproduce (for bugs)

  1. Reach maximum prosperity
  2. Set Business Assistant to manage menial slave trade
  3. End week and notice that the BA section is not displayed in the arcology updates.

Additional information

  • Release ID: (guess build ID is meant here?) 1117
  • Commit: 5ff29e3b
Edited by Qahlz