Chastity release rules don't work as intended

changed the description

It's all in saRules. Isn't "chastity" .releaseRule yours too? But to the point, you'd have to add a catch to each .releaseRules block in saRules.

Keep in mind there will be a reaction to being ordered to be chaste. Will they cheat? Disregard you and be a slut? Or are they just so frigid no sex doesn't even bother them?

Correct, the "chastity" release rules was mine. I was mostly raising the issue for documentation purposes, and just in case anyone else wanted to have a go at it to see what's going on with it.

Good things to keep in mind - I'll take those into consideration.

@DCoded I don't have time to do a dive like this right now, but it seems to me that your best bet is to search the codebase for those ".*Count" occurrences, and make sure that each instance is respecting the new new release rule.

Although, I'd also add that if you assign someone to certain jobs, they can't really perform them without increasing their counts. You need at the very least oral services to perform prostitution, public service, fucktoy, or arcade duties.

If this bit isn't functioning, might it be prudent to gate it like other alpha level content?

Probably. In all the saRules cases where it checks for .releaseRules, it needs to have a segment added for chastity.

@Cayleth There are 2,016 results combined for .oralCount, .vaginalCount, and .analCount - I'm a bit of a masochist sometimes when it comes to code, but not that much. The second bit I've already taken into consideration - this bug is coming from slaves that are assigned to work in the Servants' Quarters with slave-on-slave molestation forbidden. I also don't think it's necessary to gate it - it's stable, albeit not entirely bug-free.

@Pregmodder I'll take another look at saRules again to see if there's anything slipping through the cracks. I won't be able to push any changes to it, though, as all of my branches are currently tied up in other requests, and I don't want to bother with creating another branch just for a bugfix.

Can always pass the file along for manual merge.

For what it's worth, filtering down to the sa* files,

.analCount + == 34 results

.vaginalCount + == 29 results

I think many of the other results are events, which we can reasonably exclude.

I'm not sure I understand everything that's going on here, but I can add the check. What's the format?

Not entirely sure yet. Basically slaves that are on the "chastity" release rule shouldn't receive an increase in the different counts unless they're assigned to a sexual assignment.

"Applying "chastity" release rules to a slave do not cause their .oralCounts, .vaginalCounts, or .analCounts to become unchanged at week-end."

Well this seems sort of unreasonable, in a sense. It's not just assignments. They might have sex with the PC in saDevotion if you have energy left, for example.

I am finding a few places in saRules I can fix though. I'll work on it.

edit: hmm, on second thoughts looks like it was just the wardess. Maybe it's a part of her job to run <<saRulesRapeFetish>> <<saRulesRapeDiscoversFetish>>

Slaves on the chastity release rule shouldn't have sex with the PC, though - that's something that would be left for "restricted"+. The only way slaves on the chastity rule should have sex is if they are placed in a sexual assignment.

mentioned in merge request !3878 (merged)

closed via merge request !3878 (merged)

mentioned in commit 1d13d80c

Chastity release rules don't work as intended

Designs

Child items ...

Activity