Authentic 1.0.0.126 bug: MasterYi Highlander OnAssist does not refund a portion of AlphaStrike's cooldown
As researched by @IceCreamMan, a bug I originally fixed when restoring the Highlander spell script was actually an authentic-to-126 bug.
Highlander is meant to refund a portion of Yi's spell cooldowns on successful assist while Highlander is active, including Alpha Strike.
In the original lua, the AlphaStrikeCD checks an array of values, which appears to fail, and load nothing. Back-dated footage from the time corroborates this, as Yi never refunds a portion of his Q cooldown in historical footage from the time. Footage (Happens around 8:10 mark): https://youtu.be/B7CwRZw4aTw?t=483
This bug was fixed in 1.0.0.139, which is beyond the 1.0.0.126 target, so additional effort has been made to ensure preservation of this authentic game bug.
This is not to be fixed under any circumstances, as it was originally within the 1.0.0.126 play environment.
This issue is to be left up, to be linked to in future in case of further discussion, or to quash future attempts to fix the bug.
NOTE: Everything below this note is the original text portion of this issue from the original poster. It is kept for historical purposes.
I couldn't quite figure out how it was pulling and checking the AlphaStrikeCD values by level properly, and how to do the equivalent in the C# rendition.
While making the Assist portion of the spell functional, I have temporarily used the first value for AlphaStrikeCD from the original lua script, which is 9.
This makes the Assist portion of Highlander work, but is slightly incorrect to the original functionality of the Lua spell script.
Someone with a smarter mind needs to go and correct this, so I am listing it on the issue board for other devs. Pretty quick fix.