Abilities desync
Been trying for a while to reproduce all these issues and find their cause, I think I have found a way to replicate three of them and possible causes
These desyncs allows spells to be "cancelled" client side while the CD and damage go off serverside, but cliendside only damage and effects are applied, ability doesnt go on cd
To Reproduce
- Spells being incorrectly flagged as instant cast when they arent?? (not sure if this was the cause):
- Play any champion with a cast time (Easiest way to reproduce is a long cast while spamming the movement command in the ground at the same time, example Kassadin Q something and click the ground really fast or Vlad E while clicking the ground really fast)
- Desync between server and client CD (ability doesnt go on cd clientside)
Should be resolved in !39 (merged) (cant reproduce Vlad E thing there)
-
Spamming a attack command and a spell command causes desync
Easiest way to reproduce with Kassadin Q
- Spam attack command on something and while doing that spam Q on the target (might even not need spam attack,
- Desync between server and client CD (ability doesnt go on cd clientside)
This seems to be related to internal void IssueDelayedOrder() in ObjAIBase.cs, commenting "UpdateMoveOrder(OrderType.Hold, true);" seems to make this not happen, this is not a solution obviously but its related to that line, commenting out Caster.IssueDelayedOrder(); in void EndCast(bool noCooldown, bool execute = false) seems to have the same effect. Again, this is not a fix probably, commenting these lines makes Turrets not being able to attack you after one attack.
-
(Havent confirmed this one since its hard to reproduce)Sometimes when you cast a targeted ability your champ keeps pathing toward the target after the cast, this causes a desync:Easy way way to reproduce this:
- Play Kassadin
- Level up Kass R
- Spam move command outside of the range of Kass R while at the same time spamming R
- CD will desync
Seems to be ranged related? 99% sure its unrelated to the spamming attack command and spell one, Its unrelated to the second desync since applying the "bandaix fix" makes the spam command attack desync stop happening but not this one.