Fixes for logged errors in RM 4.2.
Starting up a new game, and as is my tradition when I'm coming back after a long break, did some scanning through logs to find anything that might be causing issues. Some of these are just related to incomplete / orphaned events, but some seem like real problems. There are also two categories (image errors and the orphaned events themselves) which I didn't fix, but I've listed at the bottom of this merge request for posterity.
Issues addressed & the logged message that I'm looking at below:
Fixed incorrect scope checking for contract taker being adult in regula_contracts.txt.
[E][jomini_trigger.cpp:686]: Inconsistent trigger scopes (task_contract vs. character) infile: common/task_contracts/regula_contracts.txt line: 122 (laamp_regula_0001:valid_to_continue)
[E][jomini_trigger.cpp:686]: Inconsistent trigger scopes (task_contract vs. character) infile: common/task_contracts/regula_contracts.txt line: 131 (laamp_regula_0001:valid_to_keep)
Removed extra can_recruit stanza in armored_footmen. Note: Only fixed the first of these - the other errors are basically saying that the triggers to disable these have no effect because these are unlocked by an innovation.
[E][pdx_persistent_reader.cpp:216]: Error: "Trigger section already read earlier: can_recruit, near line: 203" in file: "common/men_at_arms_types/00_maa_types.txt" near line: 205
[E][men_at_arms_type.cpp:933]: armored_horsemen has both an unlocking innovation (Arched Saddle) and a can_recruit trigger. The trigger will get ignored
[E][men_at_arms_type.cpp:933]: crossbowmen has both an unlocking innovation (Advanced Bowmaking) and a can_recruit trigger. The trigger will get ignored
Fixed typo where tier_county was instead written as county_tier. Additionally, performed the BOM ritual.
[E][lexer.cpp:297]: File 'events/scheme_events/fascinare_scheme/fascinare_scheme_success_events.txt' should be in utf8-bom encoding (will try to use it anyways)
[E][jomini_eventtarget.cpp:681]: Failed to find a valid event target link 'county_tier' at file: events/scheme_events/fascinare_scheme/fascinare_scheme_success_events.txt line: 1132 (fascinare_success.2100:option:trigger)
[E][jomini_scriptvalue.h:564]: Cannot read [county_tier] as a script value
[E][jomini_scriptvalue.h:345]: Badly read script value county_tier at file: events/scheme_events/fascinare_scheme/fascinare_scheme_success_events.txt line: 1132 (
Fixed some errors in a couple incomplete events for ongoing fascinare effects.
[E][jomini_script_system.cpp:284]: Script system error!
Error: has_trait trigger [ Cannot find 10 in trait database ]
Script location: file: events/scheme_events/fascinare_scheme/fascinare_ongoing_events.txt line: 746 (fascinare_ongoing.2101:option)
[E][jomini_script_system.cpp:284]: Script system error!
Error: add_character_modifier effect [ Modifier '' doesn't match expected type 'character', due to 'none' ]
Script location: file: events/scheme_events/fascinare_scheme/fascinare_ongoing_events.txt line: 923 (fascinare_ongoing.2112:option)
[E][jomini_script_system.cpp:284]: Script system error!
Error: add_character_modifier effect [ Invalid database object '' ]
Script location: file: events/scheme_events/fascinare_scheme/fascinare_ongoing_events.txt line: 923 (fascinare_ongoing.2112:option)
[E][jomini_effect.cpp:139]: PostValidate of effect 'add_character_modifier' returned false at file: events/scheme_events/fascinare_scheme/fascinare_ongoing_events.txt line: 923 (fascinare_ongoing.2112:option)
Fix stress effects which are referencing stress effects only visible in base game file to their own file.
[E][jomini_effect.cpp:546]: Unknown effect laamp_base_contract_schemes_acknowledge_success_stress_effect at file: events/scheme_events/regula_laamp_lewd_contract_scheme_events.txt line: 256 (regula_laamp_lewd_contract_schemes.0002:option)
[E][jomini_effect.cpp:546]: Unknown effect laamp_base_contract_schemes_acknowledge_success_stress_effect at file: events/scheme_events/regula_laamp_lewd_contract_scheme_events.txt line: 305 (regula_laamp_lewd_contract_schemes.0003:option)
[E][jomini_effect.cpp:546]: Unknown effect laamp_base_contract_schemes_acknowledge_failure_stress_effect at file: events/scheme_events/regula_laamp_lewd_contract_scheme_events.txt line: 354 (regula_laamp_lewd_contract_schemes.0004:option)
Adjusted some triggers with wrong variable names or incorrect scoping in regula travel events.
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: regiment_size, near line: 373" in file: "events/travel_events/regula_travel_events.txt" near line: 374
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: regiment_size, near line: 381" in file: "events/travel_events/regula_travel_events.txt" near line: 382
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: subtract, near line: 2030" in file: "events/travel_events/regula_travel_events.txt" near line: 2032
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: regiment_size, near line: 2377" in file: "events/travel_events/regula_travel_events.txt" near line: 2378
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: regiment_size, near line: 2385" in file: "events/travel_events/regula_travel_events.txt" near line: 2386
[E][jomini_trigger.cpp:686]: Inconsistent trigger scopes (landed_title vs. province) infile: events/travel_events/regula_travel_events.txt line: 5192 (regula_travel_events.3201:trigger)
[E][jomini_trigger.cpp:686]: Inconsistent trigger scopes (landed_title vs. province) infile: events/travel_events/regula_travel_events.txt line: 5197 (regula_travel_events.3201:trigger)
[E][jomini_trigger.cpp:686]: Inconsistent trigger scopes (landed_title vs. province) infile: events/travel_events/regula_travel_events.txt line: 5373 (regula_travel_events.3202:trigger)
Remove min chance modifiers which are not valid since we don't actually have any modification of the chances for different options in regula_travel_events.3203.
[E][jomini_script_system.cpp:284]: Script system error!
Error: untyped effect [ max and min chance can only be used with modifiers ]
Script location: file: events/travel_events/regula_travel_events.txt line: 5715 (regula_travel_events.3203:option)
[E][jomini_script_system.cpp:284]: Script system error!
Error: untyped effect [ max and min chance can only be used with modifiers ]
Script location: file: events/travel_events/regula_travel_events.txt line: 5731 (regula_travel_events.3203:option)
[E][jomini_script_system.cpp:284]: Script system error!
Error: untyped effect [ max and min chance can only be used with modifiers ]
Script location: file: events/travel_events/regula_travel_events.txt line: 5747 (regula_travel_events.3203:option)
[E][jomini_script_system.cpp:284]: Script system error!
Error: untyped effect [ max and min chance can only be used with modifiers ]
Script location: file: events/travel_events/regula_travel_events.txt line: 5763 (regula_travel_events.3203:option)
Address a few issues with missing values / wrong trigger names, etc for camp officers.
[E][jomini_eventtarget.cpp:681]: Failed to find a valid event target link '@basic_will_do' at file: common/court_positions/types/regula_camp_officers.txt line: 212 (head_servant_camp_officer:candidate_score)
[E][jomini_scriptvalue.h:564]: Cannot read [@basic_will_do] as a script value
[E][jomini_scriptvalue.h:345]: Badly read script value @basic_will_do at file: common/court_positions/types/regula_camp_officers.txt line: 212 (head_servant_camp_officer:candidate_score:value)
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: head_servant_camp_officer_validity_trigger, near line: 901" in file: "common/scripted_triggers/00_court_position_triggers.txt" near line: 902
[E][pdx_persistent_reader.cpp:216]: Error: "Unknown trigger type: head_servant_camp_officer_validity_trigger, near line: 906" in file: "common/scripted_triggers/00_court_position_triggers.txt" near line: 907
[E][jomini_script_system.cpp:284]: Script system error!
Error: employs_court_position trigger [ Invalid database object 'head_maid_camp_officer' ]
Script location: file: common/court_positions/types/regula_camp_officers.txt line: 151 (head_servant_camp_officer:prestige)
[E][jomini_trigger.cpp:214]: PostValidate of trigger 'employs_court_position' returned false at file: common/court_positions/types/regula_camp_officers.txt line: 151 (head_servant_camp_officer:prestige)
[E][jomini_script_system.cpp:284]: Script system error!
Error: any_court_position_holder trigger [ Invalid CourtPositionType for 'head_maid_camp_officer' ]
Script location: file: common/court_positions/types/regula_camp_officers.txt line: 152 (head_servant_camp_officer:prestige)
[E][jomini_trigger.cpp:214]: PostValidate of trigger 'any_court_position_holder' returned false at file: common/court_positions/types/regula_camp_officers.txt line: 152 (head_servant_camp_officer:prestige)
Fixed fascinare starting progress to actually take opinion into account.
So...looking at other script values in the base game...it seems like the way to add opinion to a variable is actually something like add = "scope:a.opinion(scope:b)". The save_temporary_opinion_value_as seems to only ever be used inside triggers / effects in base game code. Gotta love crazy undocumented stuff. O_O
[E][pdx_persistent_reader.cpp:216]: Error: "Unexpected token: save_temporary_opinion_value_as, near line: 26" in file: "common/script_values/regula_scheme_values.txt" near line: 29
Avoid removing flag in cult setup event when the character with the flag has died.
[E][jomini_script_system.cpp:284]: Script system error!
Error: remove_character_flag effect [ scope is dead during effect execution ]
Script location: file: events/decisions/regula_start_cult_events.txt line: 798 (regula_start_cult_event.0004:after)
Remove extra invalid backslashes in some of the regula_travel_events english locs.
[E][localization_reader.cpp:111]: Illegal localization break character (`#`) at line 124 and column 254 in localization/english/event_localization/regula_travel_events_l_english.yml
[E][localization_reader.cpp:111]: Illegal localization break character (`S`) at line 143 and column 54 in localization/english/event_localization/regula_travel_events_l_english.yml
[E][localization_reader.cpp:111]: Illegal localization break character (`S`) at line 144 and column 56 in localization/english/event_localization/regula_travel_events_l_english.yml
Fixed some missing / incomplete loc entries. Also fix a typo in regula_ridiculed_servants (was regula_riddiculed_servants) causing loc mismatch in all languages other than Korean.
[E][jomini_dynamicdescription.cpp:66]: Unrecognized loc key regula_orgy_intent_events.5021.b. file: CEventOptionDesc line: 139
[E][jomini_dynamicdescription.cpp:66]: Unrecognized loc key regula_travel_events.3001.physician. file: CEventOptionDesc line: 139
[E][pdx_locstring.cpp:93]: Key is missing localization: regula_riddiculed_servants_title
Copied picture entries missing in ai only tradition decisions from the player visible decisions.
[E][decision_type.cpp:176]: Decision picture regula_adopt_famuli_warriors_decision_ai missing entries
[E][decision_type.cpp:176]: Decision picture regula_adopt_magistri_submission_decision_ai missing entries
On the other hand: There are also a few issues in logs that I explicitly did not fix or look at fixing. I don't really know what the deal with the mipmap issues is, and the orphaned events I'm just assuming are still WIP / intentionally not hooked up yet.
[E][gfx_dds_loader.cpp:536]: Expected more data in the texture mipmaps than was actually present in file: gfx/interface/icons/vassal_stances/devoted.dds
[E][gfx_dds_loader.cpp:536]: Expected more data in the texture mipmaps than was actually present in file: gfx/interface/icons/activities/activity_regula_orgy_header.dds
[E][gfx_dds_loader.cpp:536]: Expected more data in the texture mipmaps than was actually present in file: gfx/interface/icons/court_position_types/head_servant_camp_officer.dds
[E][gfx_dds_loader.cpp:536]: Expected more data in the texture mipmaps than was actually present in file: gfx/interface/icons/culture_tradition/4-items/regula_raid.dds
[E][jomini_eventmanager.cpp:368]: Event fascinare_outcome.0004 is orphaned
[E][jomini_eventmanager.cpp:368]: Event fascinare_outcome.0005 is orphaned
[E][jomini_eventmanager.cpp:368]: Event fascinare_ongoing.2101 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_laamp_lewd_contract_schemes.0002 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_laamp_lewd_contract_schemes.0003 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_laamp_lewd_contract_schemes.0004 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_orgy_intent_events.6007 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_orgy_intent_events.6008 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_orgy_intent_events.6010 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_book_event.2100 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_blob.0001 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_challenge.0001 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_challenge.0002 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_challenge.0003 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_challenge.0004 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_intruder.0001 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_intruder.0002 is orphaned
[E][jomini_eventmanager.cpp:368]: Event orgy_main_intruder.0003 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3102 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3103 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3122 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3123 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3124 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3202 is orphaned
[E][jomini_eventmanager.cpp:368]: Event regula_travel_events.3301 is orphaned