Skip to content

Draft: WIP - save game compatibility for NoraBranch

NoraBranch introduces a new attribute mc.appt_schedule which is only set in the MainCharacter constructor, so it will only be present for new games, breaking loading of existing saves:

https://gitgud.io/lab-rats-2-mods/lr2mods/-/blob/NoraBranch/game/main_character/MainCharacter_ren.py#L135

The ideal fix is to have a mechanism to patch up existing objects for these cases.

There is the existing check_save_version label which is supposed to do this, but it only checks version number changes (a manual change usually done on releases) and not git hash changes (like in this case).

The solution would be to detect the latter case. If you guys agree with this direction, I can implement detection of git commit hash changes and finish the MR.

A simpler solution is to scrap all this and for now just fix NoraBranch to do this somewhere other than MainCharacter constructor:

if not hasattr(self, 'appt_schedule'):
    self.appt_schedule = AppointmentScheduler()
Edited by DwellsOnAHill

Merge request reports

Loading