Skip to content
Snippets Groups Projects
Commit df49f9cb authored by svornost's avatar svornost
Browse files

1. Make areRelated and relativeTerm work regardless of familyTesting. This...

1. Make areRelated and relativeTerm work regardless of familyTesting.  This fixes some bugs right away, since they are already used unchecked a few places, and it makes it a lot easier to write generic descriptions and event text without breaking things.
2. Extend relativeTerm to handle sole parent and grandparent/grandchild cases.
3. Make relativeTerm return null instead of "some unknown blood relation" if no relationship could be found between two slaves.  This was never OK to output (i.e. "$his some unknown blood relation" doesn't read right), so it ended up just being tested for everywhere (which can be done more easily with null).
4. Remove duplicate code based on familyTesting when the only difference was whether areRelated and relativeTerm or their legacy alternatives were used.  There is a lot of this.
5. Remove hasRelationP entirely (it is superseded in all use cases by areRelated).
parent bcf083c7
No related branches found
No related tags found
No related merge requests found
Showing
with 82 additions and 178 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment