Skip to content
Snippets Groups Projects
Commit 73b8a2be authored by Pregmodder's avatar Pregmodder
Browse files

Merge branch 'sub' into 'pregmod-master'

add sugarcube-2 submodule

See merge request !6802
parents b1ccf652 bc4e70ba
No related branches found
No related tags found
1 merge request!6802add sugarcube-2 submodule
[submodule "submodules/sugarcube-2"]
path = submodules/sugarcube-2
url = https://gitgud.io/Arkerthan/sugarcube-2.git
...@@ -49,4 +49,8 @@ bin/: ...@@ -49,4 +49,8 @@ bin/:
sanity: sanity:
./sanityCheck.sh ./sanityCheck.sh
.PHONY: all sanity git sugarcube:
(cd submodules/sugarcube-2/ && node build.js -6 -b 2)
cp submodules/sugarcube-2/build/twine2/sugarcube-2/format.js devTools/tweeGo/storyFormats/sugarcube-2/format.js
.PHONY: all sanity git sugarcube
Common problems: # Free Cities - pregmod
How do I start the game? ## Common problems
-Run the compile file, go to folder "bin", click the "FC_Pregmod" and play. (Recommendation: Drag it into incognito mode)
I get an error on gamestart reading "Apologies! A fatal error has occurred. Aborting. Error: Unexpected token @ in JSON at position 0. Stack Trace: SyntaxError: Unexpected token @ in JSON at position 0 at JSON.parse (<anonymous>) at JSON.value" or some variant * How do I start the game?
-clear cookies - Run the compile file, go to folder "bin", click the "FC_Pregmod" and play. (Recommendation: Drag it into incognito mode)
Everything is broken! * I get an error on gamestart reading "Apologies! A fatal error has occurred. Aborting. Error: Unexpected token @ in JSON at position 0. Stack Trace: SyntaxError: Unexpected token @ in JSON at position 0 at JSON.parse (<anonymous>) at JSON.value" or some variant
-Do not copy over your existing download as it may leave old files behind, replace it entirely - clear cookies
I can't save more than once or twice. * Everything is broken!
-Known issue caused by sugarcube level changes. Save to file doesn't have this problem and will likely avoid the first problem as well. - Do not copy over your existing download as it may leave old files behind, replace it entirely
-It is possible to increase the memory utilized by your browser to delay this
I wish to report a sanityCheck issue. * I can't save more than once or twice.
-Great, however a large majority of the results are false positives coming from those specific sections being split over several lines in the name of readability and git grep's intentionally (http://git.661346.n2.nabble.com/bug-git-grep-P-and-multiline-mode-td7613900.html ) lacking support for multiline. An Attempt to add -Pzl (https://gitgud.io/pregmodfan/fc-pregmod/merge_requests/2108 ) created a sub condition black hole. What follows are examples of common false positives that can safely be ignored; - Known issue caused by sugarcube level changes. Save to file doesn't have this problem and will likely avoid the first problem as well.
- It is possible to increase the memory utilized by your browser to delay this
* I wish to report a sanityCheck issue.
- Great, however a large majority of the results are false positives coming from those specific sections being split over several lines in the name of readability and git grep's intentionally (http://git.661346.n2.nabble.com/bug-git-grep-P-and-multiline-mode-td7613900.html ) lacking support for multiline. An Attempt to add -Pzl (https://gitgud.io/pregmodfan/fc-pregmod/merge_requests/2108 ) created a sub condition black hole. What follows are examples of common false positives that can safely be ignored:
```
[MissingClosingAngleBracket]src/art/vector/Generate_Stylesheet.tw:11:<<print "<style>."+_art_display_class+" { [MissingClosingAngleBracket]src/art/vector/Generate_Stylesheet.tw:11:<<print "<style>."+_art_display_class+" {
<<print "<style>."+_art_display_class+" { <<print "<style>."+_art_display_class+" {
position: absolute; position: absolute;
...@@ -25,8 +27,9 @@ I wish to report a sanityCheck issue. ...@@ -25,8 +27,9 @@ I wish to report a sanityCheck issue.
left: 0; left: 0;
right: 0; right: 0;
} }
```
How to mod (basic doc): ## How to mod (basic doc):
1. All sources now in the src subdir, in separate files. 1 passage = 1 file. 1. All sources now in the src subdir, in separate files. 1 passage = 1 file.
...@@ -77,7 +80,8 @@ How to mod (basic doc): ...@@ -77,7 +80,8 @@ How to mod (basic doc):
5. (optional, but recommended) Run sanityCheck before final push to catch any errors you missed. (You can ignore errors unrelated to files you changed.) 5. (optional, but recommended) Run sanityCheck before final push to catch any errors you missed. (You can ignore errors unrelated to files you changed.)
6. Make merge request through gitgud interface. 6. Make merge request through gitgud interface.
## Related repositories ## Submodules
FC uses a modified version of SugarCube 2. The sources can either be obtained preferably via [this repo](https://gitgud.io/Arkerthan/sugarcube-2) or by applying the patch to the official SC2 files. FC uses a modified version of SugarCube 2. It is integrated as a git submodule. If you are interested in modding SC2 this is a [good starting point](https://git-scm.com/book/en/v2/Git-Tools-Submodules) for using submodules. Instructions to build SC2 can be found [here](devNotes/sugarcube stuff/building SugarCube.md).
When modifying SC2 make sure to open an MR here and at the SC2 repo, so they stay in sync.
When modifying SC2 make sure to open an MR here and at the [SC2 repo](https://gitgud.io/Arkerthan/sugarcube-2), so they stay in sync.
[submodule "submodules/sugarcube-2"]
branch = fc
Subproject commit 813625f280aecab97e00eee3eb76acfbc2e15e5c
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment