Cannot change plans

I try to change which slave I'm training and I get a popup error and when I click it away I get this, Error: <<=>>: bad evaluation: Cannot read property 'employeesIds' of undefined <<= App.UI.SlaveList.slaveSelectionList( s => s.assignmentVisible === 1 && s.fuckdoll === 0, s => App.UI.DOM.link(SlaveFullName(s), (id) => {App.UI.selectSlaveForPersonalAttention(id); }, s.ID) )>> Ideas?

free-cities-20190829-173533.save

@lowercasedonkey

This is likely a sideeffect of one of your recent changes. Would you poke at it?

@ezsh mind giving me some help on this? It's probably something in the way jobs are set up but the system is difficult for me to grasp.

errors seem to be e is null and bad evaluation: this.job(...) is undefined

edit: the e in question is in _updateList(assignment), const e = document.getElementById(selectionElementId);

edit going back in merges, the switch version was fine. This was something that broke when we changed it to the OOP way.

Ok, I should have just looked at what changed. I can confirm that reverting return this.job().employeesIds.length; for the switch version I had fixes this. I really don't understand the job code well so I'll keeping looking but I think ez is going to have to fix that line if he'd rather not go back to the switch.

It was crashing because there is a facility (armory) without jobs.

Same error in head girl, recruiter and bodyguard selection screens

assigned to @ezsh

Actually seems to have been caused when 'alternate-fix-for-assign' was merged in commit 9eaaed11. I backed up to the commit just before that and it went away.

That's correct. Ez has a fix up at !5282 (merged) , just need it merged.

closed via merge request !5282 (merged)

mentioned in commit 634d423f