RA Lactation activation function Issue

Expected Behavior

When a slave is lactating, either naturally or artificially, they should be assigned to the rule with the lactation activation function

Current Behavior

When a slave is lactating, they remain on the rule they were set to before, despite the rule with the lactation activation being the highest priority.

Possible Solution

Steps to Reproduce (for bugs)

1. Have at least one slave who is lactating, by whatever means
2. Make a rule in the rule assistant with the activation function set to lactation
3. Make sure at least the lower bound is set to 1, upper bound can be set to either null or 2
4. End the week or either hit apply rules in the RA or click re-apply rules when viewing the slaves in the penthouse

Additional information

• Release ID: version: 0.10.7.1, mod version: 3.5.3, build: 1073 (Not sure if this is what Release ID meant as I couldn't find anything specifically called Release ID)
• Commit: c9a1ff20
• Save file free-cities-20200703-005958.save

changed the description

Okay for some reason the rule only works when the lower bound is set to 0 instead of 1, which doesn't make sense since having a value 0 should mean they aren't lactating, right? Setting it to null makes it so everyone gets set to the rule, which is understandable.

I'll need to poke at it, not sure what it is doing.

We are talking about lactation itself and not the lactation focused rules, right?

Probably, since there is a way to get the rule working with lactation. Not sure what it could be, maybe it considers a value of 0 and 1 as lactating and -1 as not lactating instead? Edit: I can confirm, after testing it real quick, that setting the lower bound to -1 applies it to all slaves, lactating or not, just like if it were set to null and the upper bound is set to 2 or higher meaning that probably the slave lactation value is returning -1 instead of 0 when they are not lactating. Either that or when the rule activation function is checking for lactation, it's for some reason decreasing the value by 1 before checking. Also, values -2 and under don't work either so it's definitely decreasing the value by only 1. Edit 2 (but I guess it's not the second edit): It seems that in order to get naturally lactating slaves to work with the lactating rules assistant, the lower bound has to be 0 and the upper bound has to be 2 or higher, setting the lower to 0 and the upper to 1 doesn't work. So that throws my guess as to why the rules assistant is behaving like this out the window. So it's still unknown whether it's an issue the lactation mechanic or the lactation activation function in the rules assistant. Also, setting the lower to at most -1 and the upper to 1 makes it so only non-lactating slaves are assigned to the rule while setting it to -1 and 0 or 0 and 1 doesn't work. Hope this helps you some how as it sure doesn't help me wrap my head around why this is happening. Edit 3: Scratch that. Setting upper to just 2 with lower set to 0 only works with naturally lactating slaves, for artificial lactation, the upper bound has to be 3 or higher.

It's always fun when something like this happens. It would actually explain some of the oddities I noticed while adding the lactation maintenance rule. Will look into it and see if I can figure out where it is coming from.

@svornost

You may want to look to as the last time I touched something in the RA I broke rule compatibility.

For range values, both bounds are exclusive, not inclusive. "Between -1 and 1" allows only a value of zero exactly; "Between 0 and 2" allows only a value of 1 exactly.

In other words, I think this is doing exactly what it's supposed to be doing...

That makes sense. May be worth noting somewhere in the range controls to prevent confusion, I think.

Okay, I guess that explains it. To me, when I read lower bound and upper bound, I thought those meant the minimum value and maximum value that will activate the rule since I didn't see it say anything otherwise.

closed