Skip to content
Snippets Groups Projects
New look: Off

Undefined in saDevotion

    • Closed Issue created by Pregmodder @Pregmodder

    @svornost

    Got something undefined somewhere between the retirement block and the stat crossovers.

    You can see it on Miss Anne in the penthouse in this save.

    u4pdhg.save

    Designs

      Child items 0

      2. No child items are currently assigned. Use child items to break down this issue into smaller parts.

      Activity

      • Blank_Alt
        Blank_Alt @Blank_Alt ·
        Reporter

        Fifth position in the slave array. slave.ID = 990000

        After commenting out line 486

        r.push(`${FutureSocieties.Change("Paternalist", 2)}`);

        image

        FutureSocieties.Change breaks down to:

        function FSChange(FSString, magnitude, bonusMultiplier = 1) {
		const arcology = V.arcologies[0];
		const activeFS = FSString2Property[FSString];
		// console.log('arcology:', arcology, 'activeFS:', activeFS, 'bonusMultiplier:', bonusMultiplier, 'magnitude:', magnitude, 'FSString:', FSString, 'FSSingleSlaveRep:', V.FSSingleSlaveRep);
		if (activeFS === undefined) {
			return "<span class='red'>ERROR: bad FS reference</span>";
		} else if (Number.isFinite(arcology[activeFS])) {
			if (magnitude < 0) {
				repX(magnitude * V.FSSingleSlaveRep * (arcology[activeFS] / V.FSLockinLevel) / 3, 'futureSocieties'); // Reducing the reputation impact of slaves that are not adhering to societal ideals properly
			} else {
				console.log(magnitude * V.FSSingleSlaveRep * (arcology[activeFS] / V.FSLockinLevel));
				// repX(magnitude * V.FSSingleSlaveRep * (arcology[activeFS] / V.FSLockinLevel), 'futureSocieties');
			}
			arcology[activeFS] += 0.05 * magnitude * V.FSSingleSlaveRep * bonusMultiplier;
		}
	}

        As in this case activeFS is not undefined then nothing is returned.
        Upon simply doing

        arcology[activeFS] += 0.05 * magnitude * V.FSSingleSlaveRep * bonusMultiplier;
			return ``;

        image

        Thought process.
        Searching for improves your reputation, nearly all of the hits are inside retirementThoughts() which is followed by

        retirementThoughts(slave);
			if (assignmentVisible(slave) && V.personalAttention === "sex") {
				sexualAttentionThoughts(slave);
			}
			collectiveSpirit(slave);
			statCrossovers(slave);

        assignmentVisible(slave) is true.
        V.personalAttention is not a string let along "sex" so sexualAttentionThoughts can not fire.

        Next is collectiveSpirit.
        Running

        function collectiveSpirit(slave) {
...
			if (slave.ID === 990000) {
				console.log('collectiveDevotionEffect:', collectiveDevotionEffect, 'collectiveTrustEffect:', collectiveTrustEffect);
			}

        produces

        collectiveDevotionEffect: 0 collectiveTrustEffect: 0
        if (collectiveDevotionEffect === 1) {
				if (collectiveTrustEffect === 1) {
					r.push(`Since ${he}'s ambivalent and fearful, the <span class="devotion inc">collective devotion</span> <span class="trust inc">and trust</span> of your slaves affect ${him} slightly.`);
				} else if (collectiveTrustEffect === 0) {
					r.push(`Since ${he}'s ambivalent about you, the <span class="devotion inc">collective devotion</span> your slaves feel for you affects ${him} slightly.`);
				} else {
					r.push(`Since ${he}'s ambivalent about you, the <span class="devotion inc">collective devotion</span> your slaves feel for you affects ${him} slightly, but their <span class="trust dec">general fear</span> affects ${him} too.`);
				}
			} else if (collectiveDevotionEffect === 0) {
				if (collectiveTrustEffect === 1) {
					r.push(`Since ${he}'s fearful of you, the <span class="trust inc">collective trust</span> your slaves place in you affects ${him} slightly.`);
				} else if (collectiveTrustEffect === -1) {
					r.push(`Since ${he} doesn't trust you, the <span class="trust dec">collective fear</span> your slaves feel for you affects ${him} slightly.`);
				}
			} else {
				if (collectiveTrustEffect === 1) {
					r.push(`The <span class="devotion dec">collective anger</span> your slaves feel reinforces ${his} own feelings, but their <span class="trust inc">collective trust</span> also affects ${him} slightly.`);
				} else if (collectiveTrustEffect === 0) {
					r.push(`The <span class="devotion dec">collective anger</span> your slaves feel reinforces ${his} own feelings.`);
				} else {
					r.push(`The <span class="devotion dec">collective anger</span> <span class="trust dec">and fear</span> your slaves feel reinforce ${his} own feelings.`);
				}
			}

        Doing

        if (collectiveDevotionEffect === 1) {
				if (collectiveTrustEffect === 1) {
					r.push(`Since ${he}'s ambivalent and fearful, the <span class="devotion inc">collective devotion</span> <span class="trust inc">and trust</span> of your slaves affect ${him} slightly.`);
				} else if (collectiveTrustEffect === 0) {
					r.push(`Since ${he}'s ambivalent about you, the <span class="devotion inc">collective devotion</span> your slaves feel for you affects ${him} slightly.`);
				} else {
					r.push(`Since ${he}'s ambivalent about you, the <span class="devotion inc">collective devotion</span> your slaves feel for you affects ${him} slightly, but their <span class="trust dec">general fear</span> affects ${him} too.`);
				}
			} else if (collectiveDevotionEffect === 0) {
				if (collectiveTrustEffect === 0) {
					r.push(`<span class='red'>AAAAAAAAAAAAAA</span>`);
				} else if (collectiveTrustEffect === 1) {
					r.push(`Since ${he}'s fearful of you, the <span class="trust inc">collective trust</span> your slaves place in you affects ${him} slightly.`);
				} else if (collectiveTrustEffect === -1) {
					r.push(`Since ${he} doesn't trust you, the <span class="trust dec">collective fear</span> your slaves feel for you affects ${him} slightly.`);
				}
			} else {
				if (collectiveTrustEffect === 1) {
					r.push(`The <span class="devotion dec">collective anger</span> your slaves feel reinforces ${his} own feelings, but their <span class="trust inc">collective trust</span> also affects ${him} slightly.`);
				} else if (collectiveTrustEffect === 0) {
					r.push(`The <span class="devotion dec">collective anger</span> your slaves feel reinforces ${his} own feelings.`);
				} else {
					r.push(`The <span class="devotion dec">collective anger</span> <span class="trust dec">and fear</span> your slaves feel reinforce ${his} own feelings.`);
				}
			}

        Produces image so the undefined seemed to be produced before this point.

        After only commenting out retirementThoughts(slave); the undefined is not present. image

        V.seeAge === 1, V.retirementAge === 45
        slave.indenture === -1

        V.policies.retirement
{
  "sex": 0,
  "milk": 0,
  "cum": 0,
  "births": 0,
  "kills": 0,
  "fate": "citizen",
  "menial2Citizen": 0,
  "customAgePolicy": 0,
  "physicalAgePolicy": 1
}

        slave.actualAge: 42 slave.devotion: 109 slave.trust: 74.
        It has been roughly 46 minutes since I first created this comment apparently.

        Edited by Blank_Alt
      • svornost mentioned in merge request !7682 (merged)

        mentioned in merge request !7682 (merged)

      • Pregmodder closed with merge request !7682 (merged)

        closed with merge request !7682 (merged)

      • Pregmodder mentioned in commit 64cd0500

        mentioned in commit 64cd0500

      Please register or sign in to reply