Critical embedded vector art bug.

Sugarcube 2.22.0 is apparently incompatible with <style scope> which is used in Generate_Stylesheet. I'm attempting to flag down prndev over this issue, but if anyone else can provide a solution in the meantime, that would be great. This issue risks permanantly bricking embedded vector art!

Temporary fix: Navigate to /devNotes/Sugarcube stuff and make a copy of header backup 222. Take that copy and place it in /devTools/tweeGo/storyFormats/sugarcube-2, remove header.html, and rename your copy to header.html. You will now be running on 2.21.0 again with working vector art.

Thanks man.

I used scoped styles because they were ideal for this kind of task. Unfortunately, scoped styles have been removed from Firefox and all other major browsers (https://github.com/whatwg/html/issues/552). I came up with an alternative solution back in the day, but kept the "scope" attribute in. It can safely be removed.

However, this does not seem to solve the actual problem: Within the HTML style tag, variables do not get replaced but appear in the output as raw text. As a result, the style definitions are missing and the SVG objects are rendered black. It is not only naked variable lookup, print macros do not work, either. I cannot look into this further today. I want to keep you posted in case I find out more later.

Unrelated: I like to keep up who is who. @Pregmodder, are you the same person as github.com/pregAnon?

Yep. I am ever since FCdev approached me about merging extended family mode.

Is there a discord? @Pregmodder

No and there won't be.

Understood. Thanks.

There is still a minor flaw to the vector art were there is a grey background to the images.

Edit: It is not annoying now, so I think let it be.

Found an ugly hack for this putting most of the generation in \src\art\vector\Generate_Stylesheet.tw into a local variable letting the assignment do the evalutaion and printing the variable after .. <<set _style = "<style>."+_art_display_class+" { position: absolute; height: 100%; margin-left: auto; margin-right: auto; left: 0; right: 0; } ."+_art_display_class+" .white { fill:#FFFFFF; } ."+_art_display_class+" .skin { fill:"+_skinColour+"; } ."+_art_display_class+" .head { "+_headSkinStyle+"; } ."+_art_display_class+" .torso { "+_torsoSkinStyle+"; } ."+_art_display_class+" .boob { "+_boobSkinStyle+"; } ."+_art_display_class+" .penis { "+_penisSkinStyle+"; } ."+_art_display_class+" .scrotum { "+_scrotumSkinStyle+"; } ."+_art_display_class+" .areola { "+_areolaStyle+"; } ."+_art_display_class+" .labia { "+_labiaStyle+"; } ."+_art_display_class+" .hair { fill:"+_hairColour+"; } ."+_art_display_class+" .shoe { fill:"+_shoeColour+"; } ."+_art_display_class+" .shoe_shadow { fill:"+_shoeShadowColour+"; } ."+_art_display_class+" .smart_piercing { fill:#4DB748; } ."+_art_display_class+" .steel_piercing { fill:#787878; } ."+_art_display_class+" .steel_chastity { fill:#BABABA; } ."+_art_display_class+" .outfit_base { fill:"+_outfitBaseColour+"; } ."+_art_display_class+" .gag { fill:#BF2126; } ."+_art_display_class+" .shadow { fill:#010101; } ."+_art_display_class+" .glasses { fill:#010101; } </style>">> <<print _style>>

This is the error, correct?

More or less. I'm going to leave it for prndev for now.

Looking at the change in SugarCube at https://bitbucket.org/tmedwards/sugarcube/commits/b1117fc84de4eef715c71a40ee7cdf239b7b4d47, it looks like the solution posted by @t3431710 is the way to go. The content in style tags is now handled verbatim (except that certain images can be inserted via data urls). Itbugsme that I did not think of the solution as I already am doing the very same thing to the SVG data during embedding.

Want to get it in a merge request for me?

On it. I accidentally used my professional account for the commit. Had to delete the fork and start over. Rather not want this project to be connected to my employer. Super awkward.

mentioned in merge request !1264 (merged)

closed via merge request !1264 (merged)

closed via commit c2d3b22c

closed via commit 5321cfb8

mentioned in commit Free-Cities/free-cities-pregmod@c2d3b22c

mentioned in commit Free-Cities/free-cities-pregmod@5321cfb8