This need fix!

These kind of issue would take 2 second to fix, but i think there might be more i will put it here if i saw any.

@Blank_Alt

Did you break something?

casualtiesReport() is returning HTML strings (although the way the strings are broken up, it looks like JS DOM was intended at some point.) However, the first two times it's used it's used with App.UI.DOM.appendNewElement which does not parse HTML strings.

Edit: Emptying array without using? https://gitgud.io/pregmodfan/fc-pregmod/-/blob/pregmod-master/src/Mods/SecExp/events/conflictReport.js#L625

edit2: The for loop on line 1201 is wrong as well. It seems to assume type is a string, but App.SecExp.unit.list() returns a map, not an array. I think App.SecExp.unit.list().keys() is intended.

edit3: not sure what is going on with the loop in 1244, but the typing for unit is not right. I think it works correctly, though.

This works:

		if (inRebellion) {
			for (const unit of App.SecExp.unit.list().keys()) {
				if (unit === "bots") {
					continue;
				}
				App.UI.DOM.appendNewElement("p", node, rebellingUnitsFate(unit, averageLosses));
			}
		} else {

As long as list() becomes typed as

/** @returns {Map<"bots"|FC.SecExp.PlayerHumanUnitTypeModHuman, Object>} */

"Object" is quite the downgrade in typing though. @svornost any thoughts on typing here?

Another problem authority look like this when i lose maybe when i win as well. @Pregmodder

In barrack upgrade.

I didn't lose any troop in combat.

mentioned in merge request !10242 (merged)

Well guess i'm gonna play the older version till all of this fix.

mentioned in commit f40f9e81

closed with merge request !10242 (merged)