BUG - madam experience

Slaves who have earned enough experience as a madam to have it show up on the slave page do not show up in the "experienced" selection when trying to appoint a madam. This happens both for slaves who earn experience working the position and the ones who learn it in the schoolroom.

@DrPill, can you please either attach the affected save or open developer console (F12 is the default for most browsers, FCHost: CTRL + SHIFT + J) then navigate to the management page for a slave you believe should qualify then enter the following and post the results?

typeof getSlave(V.AS).career
getSlave(V.AS).career

At least one likely root code side cause has been found though, however it's always good to confirm one's suspicions.

free-cities-20220426-032836.save

Here's a save of the madam assignment screen. Choosing "experienced" shows no one.

free-cities-20220426-033843.save

Here is a save of a slave with "He has working experience as a Madam, a DJ, a Nurse, an entertainer and a whore." on the slave's page. Trying to enter the above into the console nets the following:

typeof getSlave(V.AS).career = "string"

getSlave(V.AS).career = "retired"

This particular slave was acquired before he was 18, the "retired" career should probably not be on that list.

This particular slave was acquired before he was 18, the "retired" career should probably not be on that list.

B...but muh realism, my twice removed ex's cousin's half brother was a millionaire by six. /jk

I mean technically it can make sense if he worked for at least a day and earned (or inherited) enough to retire...but then lost it all and was sold into slavery? All while a teenager? FC truly is the libertarian paradise.

Currently writing code to add "retired" if the slave is over eighteen and now I am wondering why do it when the power of head cannon exists.
It would also likely bloat the MR even more.
"retired" is listed as valid madam experience so that part is working as expected.
It is valid for uneducated, educated and recruiters though.

Here's a save of the madam assignment screen. Choosing "experienced" shows no one.

That has now been fixed within the attached MR.

Here is a save of a slave with "He has working experience as a Madam, a DJ, a Nurse, an entertainer and a whore." on the slave's page.

They are now present in the above list.

"retired" is listed as valid madam experience so that part is working as expected.

But the slave's page says

Before he was a slave, he was retired, giving him potential as a recruiter.

Slave acquired madam experience later.

To test, I just got a slave with madam experience background. That slave shows up as having madam experience, but the ones who received it from training/work don't.

You are right.
That is what I get for typing fairly late, meant to say "is not listed as valid madam experience so that part is working as expected.".
Mind auto correction can be quite strong when it wants to be.

mentioned in merge request !10814 (merged)

mentioned in commit 54018c06

closed with merge request !10814 (merged)