Suggestion: change extension for files with JS code into .js

This would help IDEs to recognize syntax properly, allowing to put JSDoc comments and utilize them via IDE's tools.

On one condition: Someone makes me a batch file to gather all .JS files and add their contents to twineJS.txt.

Otherwise I'm keeping it as it is.

Could you explain, please, why do you want that? What is the purpose of duplicating all the JS code in the .txt file?

So it can be copied into twine since it, for who knows what reason, only takes JS in one specific place.

There is also the added issue of the sanityCheck only scanning .tw files, but that should be fixable.

Also I have the way .js files look in notepad++, but that's not exactly a good point.

So it can be copied into twine since it, for who knows what reason, only takes JS in one specific place.

Sorry, I don't understand that. What do you mean by "copying in twine"? tweego takes .js files as inputs.

I maintain a legacy Twine version. Do not ask why, the answer will be unsatisfying.

OK, I don't understand, but hope this

a batch file to gather all .JS files add put their contents to twineJS.txt

will be enough. What platform do you use? A simple shell script using grep and cat can do that. Would it satisfy your needs?

Windows, but bash seems to be able to run shell commands just fine if sanityCheck is one.

You would have to remove all the twee headers from the files as well as part of the conversion. They'd no longer be needed.

Also there are a pair of comments that would need to be flushed out in one of the files, but I'd handle that.

The sanity check is a python script and the gathering one can be written in python as well. Am I right that it has to collect contents from all .js files and join them (maybe adding comments to note where did a fragment come from)? Prepend :: StoryJS [script]? Anything else?

Yes, that would be the goal.

You could add comments, but since it would be taking everything from the JS files and would (hopefully) be run often, they shouldn't be needed.

:: StoryJS [script] and the like need to be removed completely from the .js files themselves.

If you are doing a touch of cleaning, in extendedFamilyModeJS, there are a pair of multi-line comments that break twine for no reason. If you could change them from using * to % it should fix the problem, but this is a low priority.

We can strip source comments completely when assembling this Twine file. May be a simpler option.

That would be fine. It's not like anyone should really be trying to work in it.

OK. Thank you for the explanations! I will start then.

bash seems to be able to run shell commands just fine if sanityCheck is one.

The particular code block that allows that is lines 22-25 of compile_debug+sanityCheck.bat.

The sanity check is a python script

It is a bash script (which I prefer as a format) rather than python. embed_favicon.py seems to be the only python file in the repo.
If you neeed any help ezsh, just ask.
I am thinking of attempting my own bash solution at some point, mainly as a thought exercise for now.

I'm just tired of jumping through hoops to get people to update the damn thing, so something to build it for me is beyond welcome.

I may have been thinking about this for quite a while and you just so happened to give the criteria needed for it.

It is a bash script (which I prefer as a format) rather than python.

I confused it with devTools/check.py. Thanks for correcting me.

As far as I understand, Git for windows installs some basic UNIX tools that I can use.

As I find bash scripting to be an enjoyable hobby, here is a quick prototype.Converter.sh.
The core is working when cd'd into the src/js directory.
The next few goal(s), in on particular order are to: expand it to target the other JS files, remove comments, consistently remove the initial white space (removing the new lines in files might be overkill) and hook it into a bat script.

Pregmodder does the file name absolutely have to be twine JS.txt? My impression is that it does not.

mentioned in merge request !3385 (merged)

Opened !3385 (merged) for the task. So far I renamed the files and added a simple script to join the JS code into a Twine passage. Don't know where should the script be hooked in.

@Blank, ended up with the following:

#!/bin/sh

#converts files in the current dir

# collect files with [script] tag
FILES=`grep '\[script\]' -H -R * | cut -f 1 -d ':'`
for f in $FILES; do
	# create a new name. Old names can have any of the following suffixes:
	# _JS.tw  JS.tw .tw
	nf="${f%_JS.tw}"
	nf="${nf%JS.tw}"
	nf="${nf%.tw}"
	# we might end up with an empty name, then set dir name as the file name
	[ -z "$(basename $nf)" -o "${nf: -1}" = "/" ] && nf="${nf}$(basename ${nf})"
	# append the new suffix
	nf="${nf}.js"
	echo "renaming ${f} -> ${nf}"
	# rename the file
	git mv "${f}" "${nf}" || echo "renaming ${f} failed"
	# strip Twee header from it
	sed -i 1d "${nf}" || echo "stripping Twee header failed for ${nf}"
	# strip leading empty line '/./,$!d'
	sed -i '/./,$!d' "${nf}" || echo "Stripping leading empty blank lines failed for ${nf}"
done

Let's move the discussion there?

closed via merge request !3385 (merged)

mentioned in commit 53c2b0e5