Now with possible soultion: minor Bug: Rules Assistant - Body Mod - H Areola sets desciption to 1 (maybe cause of problem) and does not apply(bug#1) + H Corset sets instead L Corset (bug#2)

Expected Behavior

see below try to reconstruct it step by step with pics

Current Behavior

Steps to Reproduce

• example rules will be attched in a bit

• (i edit / work in progress report - please give me time for reconstruction + formating)

• EDIT 2 : please excuse i complet it tommorow. my night is allready really short

• EDIT 3: should make some sense - gn8 rules if needed tomorrow

• Obervation in RA:

• Areola studs to Studded

• Corset to Applies

• then after the "first revisit of the rule" / i think after the "rule is saved" additionally when you reset the "1" the piercing resets to "No default setting" (manual setting loop)

• the Desciption turns to "1" instead of "empty" or detailed the "grey standart text (No default setting)"

• First manual character check to see result:

• there is the "1" and the corset is "L" instead of "H"

• Back to RA

• Both should be a RA error/bug because - there is no Heavy setting

• Areola studs reset to "no default setting" after that Areola description resets to No default setting

• Corset stays as applied on "Applied" but missing heavy setting

• But THEN - after revisitng an other (same settings "all heavy pirecing on all slaves) Areola resets!!

• i am not 100 % sure but it may be resets some settings after it applies this rule (keep looking at it)

• first conclusion in that mess

• the "1" in description (H Areola) is linked to the piercing?

• H + L Corset are the same?

• maybe H + L Areola are the same?

• WEHN RA is correct (exept the 1 in description loop) then reduce Char Mod settings

• WHEN Char Mod settings are correct THEN RA missing options (+ the "1" bug)

• missing:

• file init rule

• file example rule 1 + maybe 2

Additional information

mod version: 4.0.0-alpha.26, build: 1200, commit: e6bd048f

changed the description

changed the description

changed the description

maybe the root of the problem / maybe a resolution: (dirty quick from a non programmerskill)

in "\src\facilities\bodyModification\bodyModification.js"

	if (piercingLevel === 0) {
		r.push(`Remove piercings from:`);
	} else if (piercingLevel === 1) {
		r.push(`Lightly pierce ${his}:`);
	} else if (piercingLevel === 2) {
		r.push(`Heavily pierce ${his}:`);

i think which acts "globaly"

in "D:\fc-pregmod\src\js}rulesAssistantOptions.js"

class AreolaPiercingList extends ListSelector {
	constructor() {
		const pairs = [
			["none", 0],
			["studded", 1]
		];
		super("Areola studs", pairs, true);
		this.setValue(current_rule.set.piercing.areola.desc);
		this.onchange = (value) => current_rule.set.piercing.areola.desc = value;
	}
}
class AreolaPiercingString extends StringEditor {
	constructor() {
		super("Areola description", [["Default", ""]]);
		this.setValue(current_rule.set.piercing.areola.desc);
		this.onchange = (value) => current_rule.set.piercing.areola.desc = value;
	}
}

AND

class CorsetPiercingList extends ListSelector {
	constructor() {
		const pairs = [
			["none", 0],
			["applied", 1]
		];
		super("Corset piercings", pairs, true);
		this.setValue(current_rule.set.piercing.corset.weight);
		this.onchange = (value) => current_rule.set.piercing.corset.weight = value;
	}
}

class CorsetPiercingString extends StringEditor {
	constructor() {
		super("Corset description", [["Default", ""]], true);
		this.setValue(current_rule.set.piercing.corset.desc);
		this.onchange = (value) => current_rule.set.piercing.corset.desc = value;
	}
}

possible solutions: add "Heavy" in extends ListSelector:

• change 1 (applied) to light
• add 2 heavy

for example something like "\src\npc\descriptions\boobs\piercing.js" if there is a diffrence in 1 or 2

• "piercing.corset.weight"
• "piercing.areola.weight"

in a very dirty search for "piercing.corset.weight" some could easy changed to piercing.corset.weight >=1 if = 1 is present (please check for yourself - i am NO pro) same for "piercing.areola.weight"

if needed Descritption in texts arround maybe something like

• for light: delicate/small corset/studs
• for heavy: thick/heavy/big rings/studs

OR

edit the in "\src\facilities\bodyModification\bodyModification.js" for the two piercings

changed title from minor Bug: Rules Assistant - Body Mod - H Areola sets desciption to 1 (maybe cause of problem) and does not apply(bug#1) + H Corset sets instead L Corset (bug#2) to Now with possible soultion: minor Bug: Rules Assistant - Body Mod - H Areola sets desciption to 1 (maybe cause of problem) and does not apply(bug#1) + H Corset sets instead L Corset (bug#2)

couldn`t find anything for the "1" added to the descipton

maybe you pros can look into it

pretty sure the unwanted numbers appear in an "rule save action" None (piercing) = 0 Stuffed = 1