Variables NaN after new update

I loades my save into the new update and got this at the start of the next week

Does it go away after the next week? Sometimes that fires off a bunch of false positives until the new variables are put to use.

will check

nope same thing the next week

Can I get the save file for testing?

I am also having this problem so i hope it gets fixed!

Can you attach a save file?

surefree-cities-20240402-153234.save

@Pregmodder bringing this to your attention.

Thank you.

@svornost

I may need to defer this one to you. I'm just not finding a moment to be able to dive into it.

Concubine, use all holes route in saPleaseYou.js.

Starting to corner it.

She seems to be failing the quality assessments. I have no idea why.

will dig deeper tomorrow night.

Trials with other concubines with similar rules work fine.

Need to inspect the slaves.

@ViridianMaster

Did you happen to cheat edit your concubine at all?

I don't think so, the only edits were at the beginning of the game when making the first slaves.

Putting my observations here for my reference:

• Moving Starlyn off concubine duty and putting someone else (Zaida) on it stops the error from appearing
• Putting her back on next week breaks it again, so definitely something special about Starlyn
• After the slave report some of Starlyn's variables are changed:
  • "counter"
    • "anal": null
    • "mammary": null
    • "oral": null
    • "vaginal": null
• The changed counters are not directly touched in saPleaseYou.js but it is likely where the function call that causes the problem is located

Things that stand out about Starlyns data (may or may not be helpful):

• She was acquired in week -22
• intelligence is -100

Keys that exist on Starlyn that don't exist on Zaida:

• "counter"
  • "birthRape": 0
  • "crazy": 0
  • "futa": 0
  • "moves": 0
  • "preggo": 0
  • "quick": 0
  • "raped": 0
  • "virgin": 0
• "criticalDamage": 0
• "aiPrompts": { "aiAutoRegenExclude": 0, "expressionNegative": "", "expressionPositive": "", "negative": "", "pose": "", "positive": "" }
• "deferredNeed": 0
• "digestiveSystem": "normal"
• "majorInjury": 0
• "newVag": 0
• "oldEnergy": 0
• "sexualEnergy": 4
• "trueVirgin": 0
• "weaningDuration": 0

Exactly. But that's the question.

I think she is failing the quality setters in saPleaseYou, but those are super simple, so I can't see why. Tonight, I'm going to add a bunch of local debuggers to see if I can isolate the exact breaking point.

I was mainly writing the above as my own reference to help me through my attempt to find the problem. I want to start at the beginning to make sure nothing is missed

@Pregmodder Are slaves supposed to have deferredNeed? Because Starlyn does and I can't find anywhere in the coded that a slave is given it.

@ViridianMaster did you clone the player to make Starlyn? Because that is what it kind of looks like to me.

Think I found the problem, let me do some testing

It definitely has PC exclusive variables.

Also eager to find out what exactly is going on.

My original guess was wrong, but I think I am on the right track.

Pretty sure some of your math is multiplying NaN which just makes the result an NaN number.

Need to do some more digging

A single else statement missing here causes let quality; to be null, which causes this problem. Two solutions exist:

1. Add the missing else statement
2. Instead of using let quality; use let quality = 0; so that quality is never null

I am working on a merge request that adds the missing else statement and sets the default value for most (if not all) of the variables in saPleaseYou.js. Should have it done in a couple of minutes

Should be the following.

		if (target === "mammary") {
			if (slave.nipples === NippleShape.FUCKABLE && (canPenetrate(V.PC) || V.PC.clit >= 3)) {
				if (isHorny(slave)) {
					quality = 1.5;
				} else {
					quality = 1.2;
				}
			/*
			} else if (slave.nipples === NippleShape.DICKNIPS && V.PC.vagina > 0 && isPlayerReceptive()) {
				quality = 1.2;
			*/
			} else {
				if (slave.boobs >= 500) {
					quality = 1.0;
				} else if (slave.boobs < 300) {
					quality = 0.6;
				} else {
					quality = 0.8;
				}
			}
		}

mentioned in issue #5132 (closed)

mentioned in merge request !11912 (merged)

mentioned in merge request !11912 (merged)

mentioned in commit d331add6

mentioned in commit 96db02aa

closed with merge request !11912 (merged)

@JefferyJeffJefferson and @ViridianMaster please let us know if the latest build doesn't fix your issues

it does fix that issue but instead now at every week end it prompts me for seemingly every single newly pregnant slave