issue for backwards compatibility, i believe for an old save

Expected Behavior

backwards compatibility should run correctly when you hit "continue"

Current Behavior

Steps to Reproduce

1. load an old save before the current build
2. hit "continue"
3. (optional) try to use the backwards compatibility

Additional information

• Release ID:FC version: 0.10.7.1, mod version: 4.0.0-alpha.33, build: 1265.

• Commit: (if available)

• Save file

• Free_Cities-Ingenium-W01236-S00126-R01265-20241011-193807.save

Could not reproduce using the provided save on the latest commit (f421fa13). If this is not the commit you are using then update and see if it is still broken for you. If it is still broken or you are already on f421fa13 then @ me. If updating fixes your problem then please close this issue

Not in front of my computer right now but I'll try again when I get the chance

...

On Fri, Oct 11, 2024, 8:09 PM Frankly George (@franklygeorge) < gitlab@gitgud.io> wrote:

Frankly George https://gitgud.io/franklygeorge commented #5449 (comment 432045):

Could not reproduce using the provided save on the latest commit (f421fa13 f421fa13). If this is not the commit you are using then update and see if it is still broken for you. If it is still broken or you are already on f421fa13 f421fa13 then @ me. If updating fixes your problem then please close this issue

— Reply to this email directly or view it on GitLab #5449 (comment 432045). You're receiving this email because of your account on gitgud.io. Unsubscribe https://gitgud.io/-/sent_notifications/REDACTED/unsubscribe from this thread · Manage all notifications https://gitgud.io/-/profile/notifications · Help https://gitgud.io/help

Free_Cities-Ingenium-W01237-S00125-R01265-20241011-205252.save

i did a refresh of the html and the continue reappeared.

clicking saidreappear button gives this

ll try on a newer save. opened that, did a week progression, refreshing. the continue button comes back, with the same error when clicked:

this is on the updated build i just downloaded today, so this is the most recent version of all files

I would ask you what browser you are using, but I can see from the screenshots that you are using Edge

The first thing I notice is that I don't have the continue button that you have in my builds on Firefox or Edge

How did you get your HTML file. Did you build it or did you download it?

If you built it are you on the main branch? and do you have any modifications to FC or to SC?

If you downloaded it where did you get your link from? The current release or latest build links in the readme, somewhere else? If somewhere else could you provide me a link?

@Titanninja

Assuming the "Continue" button is the one just above "Saves", clicking that button reloads your most recent save, which presumably contains a state not yet updated by the backward compatibility.

The error displayed is because the loaded save is release 1254. Patch 1263 renames V.incubator.upgrade to V.incubator.upgrades, so a save at r1254 contains names not recognized by the newest r1265.

I think the backward compatibility works fine, you just have to save (not just export to disk) the newly updated state before using "Continue".

I don't think that continue button is supposed to be there and it along with the End Week link have never ran BC. FC is quite willing to let you shoot yourself in the foot in this regard

I have a suspicion that your copy of FC may have been built with an outdated copy of SC. Could you download the latest build from here and see if it also has a continue button?

@waryperry that is also what my research suggested, but I could not make the continue button appear in my locally built FC or in the latest build that I downloaded

Scratch that I got it to show up

The continue button seem to appear or disappear depending on the local save state; whether there's an autosave or not, where you end up when you load, etc. I haven't been quite able to get a hold on the behavior yet

Honestly it should just be perma-hidden; the first few times it appeared I clicked on it by mistake while advancing the EW events

just saw this,

i got the zip file directly through here and then used the simple-compiler.bat file.

Observations

These were all done using commit f421fa13

Route 1

1. load provided save
2. save using legacy save system
3. reload page
4. click the Continue button
5. no error

Route 2

1. load provided save
2. run BC
3. save using legacy save system
4. reload page
5. (BC reruns since we saved on that passage)
6. click the Continue button
7. no error

Route 3

1. load provided save
2. run BC
3. go to main menu
4. save using legacy save system
5. reload page
6. click the Continue button
7. no error

The Continue button seems to only work with the legacy save system

@Arkerthan We should probably just disable this as @waryperry suggested

I could not reproduce the issue using the provided save using commit f421fa13. Even running end of week without running BC didn't cause a issue. Neither did opening the incubator

@Titanninja The save causing the issue is likely your most recent save created with the legacy save system not the save file you have provided. See if loading the latest legacy save using the Saves button produces the same result. @ me with that save if running BC on it doesn't fix the error message

Note that the continue button does appear/work with the new save system as well; I haven't used the legacy system ever since the new one was introduced. In concept it's useful, but again it should be either perma-hidden or only appear on the start/welcome page.

i will also note that the legacy file itself does work as intended once all the compats are smoothed over, it's just that strange moment with refreshing the page.

also i downloaded the latest build from the above comments just to see and it gave the same result.
since it just seems to be a strange thing about the continue button (running the file directly from saves loads it no problem) i'm gonna leave this for now

@Titanninja this issue is likely due to being on a older build. There was a bug that was fixed with releaseID 1267 that is likely causing this. See #5451 (comment 432127) for more info

mentioned in merge request Arkerthan/sugarcube-2!22 (merged)

added Bug label

changed due date to October 20, 2024

assigned to @franklygeorge

@Titanninja I am closing this issue. If you are still having problems in this regard then reopen this issue and @ me

closed