$PC.engineering review

@kopareigns @klorpa @lowercasedonkey

Does this actually do anything? I'm looking for where it modifies prices for things and am not seeing anything.

mentioned in commit Blank/fc-pregmod@aa18318f

The variable $upgradeMultiplierArcology effects around 210 items. However it is either 1,0.8 or 0.6 and the only way to get it to 0.6 is select "medicine" as your career as "arcology owner" sets it to 0.8 (which I am fine with personally due to balancing).

I have whipped up a function to correct this, using HSM as a template so at <=-1000 the returned value 1.5 other than that it mirrors the above state.

mentioned in merge request !3803 (merged)

I think you had some typos there, @Blank, but it is "engineer" for 0.6 and not medicine.

I don't see anywhere that $PC.engineering modifies prices either.

Taking the engineer PC origin lowers prices; the actual engineering skill does not. The only instance of "<<if $PC.engineering..." not relating to simple character description is in one of the FCTV shows.

It should definitely be akin to HSM() then in that prices steadily lower the better you get. That said, @Blank please pick a better name than HSM(), you know, something descriptive as to what the function is and does?

mentioned in merge request !3846 (merged)

closed via merge request !3846 (merged)

mentioned in commit b67affc7