Couldn't find slaves with freckles or birthmark in alpha ver 32 to 35
I just return to playing FC again after sometimes and notice that there's no slaves with freckles or birthmark anywhere despite seeing it pretty often in older versions. Slaves with beauty marks/moles still appear regularly. I don't see even one in my 300th week save on alpha 35, not even when I started a new save plus and change location. I decided to test with older versions from 31-34 to see if it's true:
- All the test saves are set to Only Continental trade, in urban Scandinavia, to make sure most of the slaves will be white with higher chance having freckles.
- Then I check out 50 slaves in the market and note how many of them have Markings.
=> Saves of ver 32-34 give me the same result: I would very least get 5 slaves with beauty marks/moles but no freckles or birthmark. But ver 32 also provides more description variant for the moles compare to newer version (Though I didn't check this thoroughly). Ver 31 however gives me 1-2 slaves with beauty marks, 2 with large liver-colored birthmarks and 1 with light freckles within 50 slaves. To make sure, I went back to ver 32's save and check out 100 slaves instead this time and the result is unchanged. I then did the same with ver 35's, 100 slaves and none of them has freckles or birthmark either.
One anon I was talking to in the thread about this, took a look at the uncompiled generateNewSlaveJS file's code and saw that the codes determining a slave's marking was changed in ver 32. He said: "Looking in the file /src/npc/generate/generateNewSlaveJS.js from the uncompiled versions 31, 32 and 35, the code that gives them the markings was changed between 31 and 32. So yeah, I think you caught something and from version 32 onwards the game is not generating slaves with either freckles or birthmarks because of some issue in the new code. My guess is that for fair skinned slaves it now rolls a number between 1 and 4 to determine whether they should have markings at all, with 1 meaning yes, and then it's supposed to roll again 1-8 in order to determine which kind of marking she's supposed to get, but instead it reuses the 1 it rolled previously, so they always get a beauty mark. A similar thing happens for darker or paler slaves, they roll 1-8, 1 means they get markings, and afterwards they are supposed to roll again 1-2 with 1 meaning beauty mark and 2 meaning birthmark, but the code reuses the 1 it had already rolled so they all get beauty marks."
I posted an identical issue previously but accidentally marked it as "confidential" so I don't think it shows up. So I'm reposting it again, I hope it's ok