BC does not delete invalid variables

Expected Behavior

After running BC, any variables not in App.Data.defaultGameStateVariables will be deleted

Current Behavior

Variables are not deleted

Steps to Reproduce

1. Create a new game
2. Open Terminal
3. Type V.abc = 123
4. Run BC
5. Open Terminal
6. Type V.abc
7. See that abc exists and has value 123

Additional information

• Release ID: FC version: 0.10.7.1, | mod version: 4.0.0-alpha.35, | build: 1280
• Commit: 1496ec73
• Save file

added Bug label

assigned to @franklygeorge

Variables are not deleted

This is by design. The new patching system expects you to explicitly clean up unused properties. There are at least two reasons you would want to do it this way instead of auto deleting properties from V.

1. An auto delete feature would delete anything that is accidentally removed from App.Data.defaultGameStateVariables with no good way of recovering that data
2. Some people have different branches with different modifications. We don't want to be breaking said saves just because we removed that data when they accidentally loaded into the wrong branch

Requiring a patch to be made to remove unneeded properties can be extra work, but in most cases we aren't truly removing properties anyways, instead we are often refactoring how the existing data is stored. As such it makes sense to move/convert the data and then remove the old properties from V as needed

Makes sense.

This comment should really be adjusted though:

https://gitgud.io/pregmodfan/fc-pregmod/-/blob/pregmod-master/js/003-data/gameVariableData.js#L2