Fixes batch (!10643) · Merge requests · pregmodfan / fc-pregmod · GitLab

Snippets Groups Projects

Merged Blank_Alt requested to merge Blank_Alt/fc-pregmod:fixesBatch into pregmod-master 3 years ago

2 unresolved threads

Closes #3866 (closed).
Resolves sanity check reports.

Edited 3 years ago by Blank_Alt

Activity

Blank_Alt added 1 commit 3 years ago
added 1 commit

ae4b5365 - fixPitBC

Compare with previous version
Blank_Alt changed the description 3 years ago

changed the description
Arkerthan @Arkerthan started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Blank_Alt
Last reply by Arkerthan 3 years ago

Blank_Alt changed the description 3 years ago

changed the description

Blank_Alt added 21 commits 3 years ago

added 21 commits

52c05a92...00640173 - 19 commits from branch pregmodfan:pregmod-master
157fa37e - Merge remote-tracking branch 'upstream/pregmod-master' into fixesBatch
3916e7e6 - tweakPitBC

Compare with previous version

Blank_Alt changed the description 3 years ago

changed the description

Blank_Alt resolved all threads 3 years ago

resolved all threads

Blank_Alt @Blank_Alt 3 years ago

Author Reporter

@Pregmodder, this is ready to merge at some point as-is.
Thoughts on clamping deathSeed to 100 or some other maximum?
With this MR previously high negative values are converted into high positive values which may not be intended.

Edited 3 years ago by Blank_Alt
Pregmodder @Pregmodder 3 years ago

Maintainer

I'll need to stare at it a bit.

And make sure nothing involving the pit is in here, that merge was reverted.
svornost @svornost 3 years ago

Reporter

The change to deathSeed is clearly not right...it makes older, sicker slaves LESS likely to die than younger, healthier ones.
Blank_Alt @Blank_Alt 3 years ago

Author Reporter

Reverted for now to reduce MR scope.
Please register or sign in to reply

brickode @DCoded started a thread on an old version of the diff 3 years ago

Resolved 3 years ago by Blank_Alt

Blank_Alt added 1 commit 3 years ago

added 1 commit

83905d50 - Implement suggestion

Compare with previous version

Blank_Alt added 1 commit 3 years ago

added 1 commit

781c37ca - Revert deathSeed changes

Compare with previous version

Blank_Alt changed the description 3 years ago

changed the description

Pregmodder @Pregmodder started a thread on the diff 3 years ago

src/endWeek/player/prInflation.js

206	206	}
207	207	} else if (PC.inflationType === "food") {
208	208	if (PC.weight < 200) {
209		r.push(`It should surprise noone that you <span class="lime">rapidly gain weight</span> with all the binge eating.`);
Pregmodder @Pregmodder 3 years ago Maintainer nobody? The thought is that it should be of no surprise that the diet makes you gain weight. Please register or sign in to reply

Blank_Alt added 1 commit 3 years ago

added 1 commit

bf0b5749 - Implement suggestion - II

Compare with previous version

Pregmodder merged 3 years ago

merged

Pregmodder mentioned in commit 3 years ago

mentioned in commit 57dc9f3c

DrPill mentioned in issue #3873 (closed) 3 years ago

mentioned in issue #3873 (closed)

Please register or sign in to reply