Encyclopedia Slave Leadership

• Said section of !10927 (merged), converted over to the desired format. (src/gui/Encyclopedia/encyclopedia.js is added but not implemented, mainly to help ease future conversions.)
• showArticleInDialog is only used within src/gui/Encyclopedia/encyclopediaDialog.js, so it seems redundant to expose it.
• Adds a minor tweak to makeLinkDOM which should help improve readability for links where text and article are identical.

added 1 commit

• f395372a - Latest code - V

Compare with previous version

changed the description

added 1 commit

• 7e0fd5f0 - Add warrning message

Compare with previous version

added 1 commit

• 852e9cdd - Update note

Compare with previous version

What's going on with encyclopedia.js?

added 1 commit

• 108aaf05 - Space to Tabs, implement suggestions and minor encylopedia formatting.

Compare with previous version

resolved all threads

added 1 commit

• aefd0880 - move encyclopedia.js

Compare with previous version

added 1 commit

• 6dfbb13b - Minor tweak

Compare with previous version

resolved all threads

Did the related links get moved deeper into the file or something? Hard to track things like that down at times.

Did the related links get moved deeper into the file or something? Hard to track things like that down at times.

Related links for slaveLeadership has been moved from the dedicated twine file (with manual spaced setup) to the end of the relevant JS file that also contains the applicable articales (now using automatic spacing due to App.UI.DOM.generateLinksStrip).

All tested?

Yes, no errors to report.

merged

mentioned in commit bc94d960

mentioned in merge request !10982 (merged)

mentioned in merge request !10981 (merged)

mentioned in merge request !10984 (merged)

mentioned in issue #4234 (closed)

mentioned in merge request !11026 (merged)