prDiet minor tweaks
Noticed that breast redistributors dropped one of my slaves to a boobs value of 35. Have gone through the code and added limits to risky sources of breast shrinkage, to avoid breast size falling below the current flat value of 100. Have two major concerns before I un-draft:
-
Did I go too far adding the drug cessation conditions to PC breast redistributors?
-
More importantly, should this be setting
Math.max(x.boobs, 100 + x.boobsImplant + x.boobsMilk)
instead ofMath.max(x.boobs, 100)
as I currently have it? I'm pretty sure I'll need to anywhere that defines boobSize, but not sure if it's warranted elsewhere.
UPDATE: This MR now just tweaks some boobSize comparisons and spaces out a subtraction operation.
Merge request reports
Activity
Technically, as long as it's not 0 or below, it is a valid breast value. For the most part it's considered irrelevant, but it does delay growth in rare cases, which is why it isn't just clamped to 100 during cleanup.
Drug cessation should happen in the drugExpiry() block or equivalent, something that the slave side needs to be updated to actually do.
Whoops, completely overlooked that block. Should I just discard all of these changes, then?
I think if nothing else, switching any instances of
boobSize >= 100
toboobSize > 100
would at least make sense.Edited by Anu
added 2 commits
mentioned in commit e8f827a7