Skip to content
Snippets Groups Projects

Use correct branding method for TCR

Merged Anu requested to merge Anu/fc-pregmod:anu-fix into pregmod-master

I noticed that I couldn't remove the Cattle Ranch brand from any of my cows or heifers, and found in testing that the bulls' brands were removable. I've copied the method used for bulls over the presumably much older method used for cows and heifers, and all works properly. I searched for any other instances of the old method elsewhere in the code, just in case there were other remnants, but they all occur in datatypeCleanup to handle even older brand objects.

Currently, BC does not seem to convert the outdated format of brand that the Cattle Ranch was applying into the current format - maybe because all the old-format brands were supposed to have been caught in earlier patches. Might be a task for someone more comfortable with writing BC patches.

Merge Checklist
  • I have read CONTRIBUTING.md
    • and
      • my code editor has
        • ESLint support enabled
        • TypeScript support enabled
        • some form of spell checker
          • We suggest using a spell checker compatible with cSpell if possible
      • my changes compile successfully and seem to work properly
      • I am using the simple compiler (simple-compiler.[bat or sh])
      • I am using the normal compiler (compile.[bat or sh])
      • this is my first merge request
      • the changes in this merge request comply with the coding style defined in CONTRIBUTING.md
Changes made
  • Replaces old, broken brand-assignment method used for Cattle Ranch cows and heifers with the updated method used for bulls

Things left to do

  • code review (this is done by one or more people other than you)
  • final tests
  • let Pregmodder know that this is ready for merging
Edited by Anu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Anu marked the checklist item final tests as completed

    marked the checklist item final tests as completed

  • Author Contributor

    @Pregmodder This is ready to go, unless another dev wants to piggyback a BC fix onto this MR.

  • Anu marked the checklist item let Pregmodder know that this is ready for merging as completed

    marked the checklist item let Pregmodder know that this is ready for merging as completed

  • merged

  • Pregmodder mentioned in commit 0d661f7d

    mentioned in commit 0d661f7d

Please register or sign in to reply
Loading