Manual Preg Events with Preg/Cycle Unknown Support
1 unresolved thread
1 unresolved thread
Description and notes
- Adds back manual impreg events when their cycle is unknown and they are not menstruating.
- Uses the
V.temp
to both prevent repeated attempts and to prevent regular impreg events from saPregnancy from happening. - Adds ignore cycle variable to a couple of those other preg checks.
- PC impreg adds more than 1 sex count now.
- Small failure rate even on fertile week when
menstruationKnown > 0
. - Adds a few TODOs.
- Fixes small display edge case where
Fertile?
is shown even whenmenstruationKnown === 0
.
Merge Checklist
-
I have read CONTRIBUTING.md - and
- my code editor has
-
ESLint support enabled -
TypeScript support enabled -
some form of spell checker - We suggest using a spell checker compatible with cSpell if possible
-
-
my changes compile successfully and seem to work properly -
I am using the simple compiler ( simple-compiler.[bat or sh]
) -
I am using the normal compiler ( compile.[bat or sh]
) -
this is my first merge request -
the changes in this merge request comply with the coding style defined in CONTRIBUTING.md
- my code editor has
- and
Things left to do
-
code review (this is done by one or more people other than you) -
final tests -
let Pregmodder know that this is ready for merging
Edited by humungusluver
Merge request reports
Activity
@Pregmodder only thing I was not 100% sure about was how these interact with Universal Rules. I think they should be priority over them, and should be priority once we move them to part-time assignments eventually.
mentioned in commit 49d2a429
Please register or sign in to reply