Skip to content
Snippets Groups Projects

Fix #5644

Merged Frankly George requested to merge franklygeorge/fc-pregmod:fix-5644 into pregmod-master

Description and notes

Fixes #5644 (closed) by calling App.Mods.SecExp.Obj.Init() when the Security Expansion mod is enabled/disabled instead of calling it during BC like it was in the past

Merge Checklist
  • I have read CONTRIBUTING.md
    • and
      • my code editor has
        • ESLint support enabled
        • TypeScript support enabled
        • some form of spell checker
          • We suggest using a spell checker compatible with cSpell if possible
      • my changes compile successfully and seem to work properly
      • I am using the simple compiler (simple-compiler.[bat or sh])
      • I am using the normal compiler (compile.[bat or sh])
      • this is my first merge request
      • the changes in this merge request comply with the coding style defined in CONTRIBUTING.md
Changes made
  • Call App.Mods.SecExp.Obj.Init() when the Security Expansion mod is enabled/disabled at game start or on the options page
  • Also calls App.Mods.SecExp.Obj.Init() during verification just in case the save is stuck in an in between state

Things left to do

  • code review (this is done by one or more people other than you)
  • final tests
  • let Pregmodder know that this is ready for merging
Edited by Frankly George

Merge request reports

Approval is optional

Merged by PregmodderPregmodder 1 month ago (Mar 25, 2025 6:42pm UTC)

Pipeline #96439 passed

Pipeline passed for ebec69d6 on pregmod-master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading