Spelling, Formatting, Type defs, Bug fixes, and Trinket rework

Description and notes

This is the first of roughly three merges I will be doing to help facilitate implementation of the changes in !12381 (closed).

Merge Checklist
  • I have read CONTRIBUTING.md
    • and
      • my code editor has
        • ESLint support enabled
        • TypeScript support enabled
        • some form of spell checker
          • We suggest using a spell checker compatible with cSpell if possible
      • my changes compile successfully and seem to work properly
      • I am using the simple compiler (simple-compiler.[bat or sh])
      • I am using the normal compiler (compile.[bat or sh])
      • this is my first merge request
      • the changes in this merge request comply with the coding style defined in CONTRIBUTING.md
Changes made
  • The GitLens VSCode extension changed how it works and now requires some extra configuration for some features when using a not default GitLab instance. These have been added to .vscode/settings.template.jsonc
  • Lots of type def additions and some changes
  • Changed two instances of ephebephile to ephebophile and added several words to the dictionary
  • Trinkets have been reworked. Not completely sure I like my implementation, but it should be a little easier to understand (patched)
  • I don't completely like what I had to do in js/003-data/constants.js to get type defs to work nicely with an Object.freeze(). I spent too much time researching and trying to find a better option. Please let me know if there is a better way to implement this
  • js/003-data/gameVariableData.js
    • aiChat was false, but all references to it expect it to be a number so I have changed it to 0. Since it being false doesn't seem to cause any problems with how the code is currently written I didn't take the time to patch V
    • tabChoice has been changed from {Main: "all"} to {Main: "penthouse"}. A recent UI change put favorites at the front of the tab list and since all is no longer a valid tab FC was defaulting to that empty tab for new games. It now defaults to the penthouse tab as it used to
    • deathIDs, burstIDs, birthIDs, and induceIDs were removed as they aren't used anywhere (patched)
  • src/art/genAI/archivingAI.js
    • Minor changes
    • Correct type defs
  • src/data/patches/patchUtils.js
    • Patches can now define tool objects which hold functions for reuse in that patch. This is useful in some rare instances
  • CHANGELOG.md
    • Fixed the FCHost disclaimer for alpha.35 mentioning alpha.34 instead
    • Reworded the JoiPlay disclaimer
    • Added unreleased changes
  • README.md
    • Added the JoiPlay disclaimer

Things left to do

  • code review (this is done by one or more people other than you)
  • final tests
  • let Pregmodder know that this is ready for merging
Edited by Frankly George

Merge request reports

Loading