Fix #5698

Description and notes

Closes #5698 (closed)

App.Facilities.Incubator.init() was removing the incubator like it was supposed to, but then it was initializing it again in the same function call

Merge Checklist
  • I have read CONTRIBUTING.md
    • and
      • my code editor has
        • ESLint support enabled
        • TypeScript support enabled
        • some form of spell checker
          • We suggest using a spell checker compatible with cSpell if possible
      • my changes compile successfully and seem to work properly
      • I am using the simple compiler (simple-compiler.[bat or sh])
      • I am using the normal compiler (compile.[bat or sh])
      • this is my first merge request
      • the changes in this merge request comply with the coding style defined in CONTRIBUTING.md
Changes made
  • Changed App.Facilities.Incubator.init()'s state param to be decommission and install instead of base and install
  • Made is so that calling App.Facilities.Incubator.init('decommission') would not do an install right after decommissioning

Things left to do

  • code review (this is done by one or more people other than you)
  • final tests
  • let Pregmodder know that this is ready for merging

Merge request reports

Loading