Skip to content
Snippets Groups Projects

Alternative fix to duped slaves

Merged kopareigns requested to merge kopareigns/fc-pregmod:alt-fix into pregmod-master

Continuing from the issue in #104 (closed), I figured out why removeSlave wasn't working properly.

This is an alternative fix to !1835 (merged). I don't know enough about javascript to tell you which is better. I guess the advantage of this is that both $slaves and $slaveIndices are modified at once in the same place. Your call if you want to merge.

Edited by kopareigns

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading