Skip to content
Snippets Groups Projects

Possible fix

Merged kopareigns requested to merge kopareigns/fc-pregmod:preg-overhaul into pregmod-newcontent1_0

Might be a fix to the seBirth issue mentioned. I don't have any convenient saves for testing, so I can't be too sure about anything here.

Biggest things that seemed like issues:

  • WombReserveCount counts fetus objects in .womb, not .curBabies. Solution: just use a for loop over the .curBabies array.
  • _curBabies was being decremented in the loop where children are sent to the incubator/nursery. Solution: don't decrement it. (If I had to guess, this was the source of the reported problem).

Other than that, slightly improved some descriptions, removed the _origReserve and _origReserveNursery because they were effectively nothing more than duplicates of _cToIncub and _cToNursery (or vice versa), and got rid of a couple if-else checks that would always fall into the first check.

As an aside, I can't for the life of me think of what the nomenclature for "curBabies" is. In particular, the "cur" part.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Current. Essentially it is the number of babies born in that birth event. Usually all, but can be partial due to superfetation/broodmother. Also shorter and safer to call than .pregType over and over.

    _curBabies does need to be decremented by incubator/nursery departure so that the event can see if there is still anything left after that to run the 'send to orphanage' and other such options on.

  • Problem would also likely exist in csec and sePlayerBirth.

  • kopareigns added 1 commit

    added 1 commit

    Compare with previous version

  • Put the decrementing back in because apparently I couldn't think when I did this last night, and updated a few other passages. The changes to slaveInteract were purely done with find/replace to remove dependence on .reservedChildren and .reservedChildrenNursery

  • Pregmodder mentioned in commit 47e5f670

    mentioned in commit 47e5f670

  • merged

Please register or sign in to reply
Loading