Skip to content
Snippets Groups Projects

ITT SecExp suggestions and general tweaks (Finally ready to be merged)

Merged Blank requested to merge Blank/fc-pregmod:SecExp_BulkUpgrade into pregmod-master

Changelog.

  • Ideally slightly tweaks attack and rebellion pacing.
  • Moves the HSM function to utilJs.
Edited by Blank

Merge request reports

Approval is optional

Merged by PregmodderPregmodder 6 years ago (Feb 7, 2019 5:08am UTC)

Merge details

  • Changes merged into pregmod-master with 813103a6.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Blank changed the description

    changed the description

  • Don't mix temps like that, it's confusing; they should stay confined to their passage only. I'd strongly prefer you left the cost calcs where there were instead of having them split between a function and the passage.

  • Author Contributor

    I initially tried it as such however the temp variables did not seem to update. Would you be fine with the effected passages being inside their own function that has access to those variables as raw JS?

    Edited by Blank
  • ezsh
  • Blank resolved all discussions

    resolved all discussions

  • Just keep it in its own calc function like you have it then.

  • Blank added 1 commit

    added 1 commit

    Compare with previous version

  • Blank resolved all discussions

    resolved all discussions

  • Blank added 1 commit

    added 1 commit

    Compare with previous version

  • Blank unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Blank changed title from WIP: SecExp suggestions to ITT SecExp suggestions (ready for review/merge)

    changed title from WIP: SecExp suggestions to ITT SecExp suggestions (ready for review/merge)

  • Blank changed the description

    changed the description

  • Blank marked as a Work In Progress

    marked as a Work In Progress

  • Blank changed title from WIP: ITT SecExp suggestions (ready for review/merge) to WIP: ITT SecExp suggestions

    changed title from WIP: ITT SecExp suggestions (ready for review/merge) to WIP: ITT SecExp suggestions

  • Blank added 1 commit

    added 1 commit

    Compare with previous version

  • Blank unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Blank changed the description

    changed the description

  • Blank marked as a Work In Progress

    marked as a Work In Progress

  • Blank changed title from ITT SecExp suggestions to WIP: ITT SecExp suggestions and general tweaks

    changed title from ITT SecExp suggestions to WIP: ITT SecExp suggestions and general tweaks

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading