pubertyXX/XY fixes

Instead of setting them on generation, we'll set them on acquirement instead. Related to #484 (closed)

Then this causes problems with the sales descriptions.

What about adding a cleanup to acquisition to correct hero slave puberties or even to the JS function that builds them?

The only descriptions that .pubertyXX/XY effect, are the slaveSummaryWidget descriptions, and those don't show unless you're already on the slaves array. The sales descriptions only use .pubertyAgeXX/XY.

The fact of the matter is that the hero slaves (outside the cheat ones) never have .pubertyXX/XY set. Unless they get the right surgeries. It's not set when they're acquired, it's not set in endWeek, it's just never set. This includes the ones obtained at the very beginning of the game.

It didn't give any errors previously because most of the code only checks them against 0. And if you're only checking against 0, undefined and 1 are equivalent. For example, if you changed this line to have slave.pubertyXX !== 1 instead, all the hero slaves would show as not ovulating yet.

What a tangled mess I managed to make out of that one.

I'd still rather keep things in slaveGen, though. What do you think of adding a setter to getHeroSlave()?

added 1 commit

• 3dd5c99d - Update

Compare with previous version

added 1 commit

• 42882159 - semicolon

Compare with previous version

Should now work as requested

There hero slave portion would need a def check as well to prevent it from overriding anything preset.

Actually, now I'm having trouble figuring out how a player would be able to make a hero slave that hasn't gone through puberty.

Given that it's not preset for any but the cheatmode hero slaves, this shouldn't be a problem. Also this is the same check that gets run in saLongTerm effects every week. So even if there is some weird preset, it should have been designed to pass this check anyways.

Oh right, I forgot that it was in conjunction with .puberty__Age.

merged

mentioned in commit c55d683e