Skip to content
Snippets Groups Projects

Don't run pronounReplacer on undefined or 0.

Merged svornost requested to merge svornost/fc-pregmod:fixes into pregmod-master

This MR just puts the logic back to how it was before it was moved to JS. prestigeDesc is checked on the very next line anyway. I'm not sure that this fix is correct, since you added a new comment on this line too that I don't understand.

As it is now, it'll throw errors. If this fix isn't correct, and the logic change on this line was intentional, we'll need a different fix for it. pronounReplacer can't handle 0 as input and pornPrestigeDesc can definitely be 0, so we have to check it.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading