Skip to content
Snippets Groups Projects

Ng+

Merged Ng+
lowercasedonkey/fc-pregmod:NG+ into pregmod-master
1 unresolved thread
Merged lowercasedonkey requested to merge lowercasedonkey/fc-pregmod:NG+ into pregmod-master
1 unresolved thread

#1489 (closed) got me thinking and I realized our new shredder/whitelist system didn't handle NG+ terribly well.

To address this I have reviewed the way the game used to work, and moved values that were always set to default into a new object, App.Data.resetOnNGPlus. I then stripped out any duplicates from App.Data.defaultGameStateVariables.

This makes them two halves of a coin. If you check them both together in "polite mode" (setNonexistantProperties()), they won't overwrite anything. autoshred() now also concats the two and consults the combined set before deleting anything.

However, by having resetOnNGPlus in a distinct object, I can use it in boss mode and overwrite player settings as well to create NG+.

Small detail, NG+ screen ran BC on every refresh, and it refreshes a lot. It uses a few globals to survive this, but they are not needed anywhere but that page. Rather than putting them in the whitelist, I check if they are defined on first load. Barring them being leftover from another NG+ where BC hasn't been run yet, this should make sure BC is run once while preserving original functionality. Should also make the scene faster since it doesn't need to run BC every refresh.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply