Skip to content
Snippets Groups Projects

SecExp: Remove hasFought global flags

Merged svornost requested to merge svornost/fc-pregmod:fixes into pregmod-master

Inspired by comments in !7322 (merged)

hasFoughtBattleOnce, hasFoughtMajorBattleOnce, and hasRebelledOnce are entirely redundant with the global counters (battlesCount, majorBattlesCount, and rebellionsCount), so just use the counters instead of tracking everything twice. Duplicate data is bad data.

Also deduplicates a bulk of the description text between the first and subsequent major battle.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading